Skip to content

Add transaction around mass mounts operations - #32038

Merged
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/only-update-indexes-after-changing-all-mounts
Mar 8, 2023
Merged

Add transaction around mass mounts operations#32038
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/only-update-indexes-after-changing-all-mounts

Conversation

@nickvergessen

@nickvergessennickvergessen commented Apr 21, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessennickvergessen added this to the Nextcloud 25 milestone Apr 21, 2022
@nickvergessen
nickvergessen requested review from a team and vanpertsch and removed request for a teamApril 25, 2022 06:58
@nickvergessen
nickvergessen requested review from a team and blizzz and removed request for a team and vanpertschJune 3, 2022 12:17
@PVince81

PVince81 commented Jun 10, 2022

Copy link
Copy Markdown
Member

@icewind1991 please review and evaluate if still relevant for the new style FS code in 24

@blizzz

blizzz commented Jul 7, 2022

Copy link
Copy Markdown
Member

/rebase

@nickvergessen
nickvergessenforce-pushed the bugfix/noid/only-update-indexes-after-changing-all-mounts branch from 448f17b to e4e8033CompareJuly 8, 2022 08:56
@github-actions

github-actionsBot commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

Possible performance regression detected

Show Output
13 queries added
≠ /remote.php/dav/files/test with 5 queries added
+ UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
+ "START TRANSACTION"
+ "COMMIT"
+ "START TRANSACTION"
+ "COMMIT"
≠ /remote.php/dav/files/test/test.txt with 1 queries added
- UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
+ "START TRANSACTION"
+ "COMMIT"
≠ /remote.php/dav/files/test/many_files with 4 queries added
+ "START TRANSACTION"
+ "COMMIT"
+ "START TRANSACTION"
+ "COMMIT"
≠ /remote.php/dav/files/test/new_file.txt with 2 queries added
+ "START TRANSACTION"
+ "COMMIT"
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
- UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
+ "START TRANSACTION"
+ "COMMIT"

This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@blizzzblizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzzblizzz mentioned this pull request Mar 7, 2023
Merged
@nickvergessen

nickvergessen commented Mar 7, 2023

Copy link
Copy Markdown
MemberAuthor

/rebase

@nickvergessen
Add transaction around mass mounts operations
6b0cef6
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nextcloud-command
nextcloud-commandforce-pushed the bugfix/noid/only-update-indexes-after-changing-all-mounts branch from e4e8033 to 6b0cef6CompareMarch 7, 2023 19:59
@nickvergessen
nickvergessen merged commit 11a0cb7 into masterMar 8, 2023
@nickvergessen
nickvergessen deleted the bugfix/noid/only-update-indexes-after-changing-all-mounts branch March 8, 2023 07:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzzblizzzblizzz approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: filesystem

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@PVince81@blizzz@CarlSchwan