Uh oh!
There was an error while loading. Please reload this page.
remove button shadow effect, fix #3203 - #3204
Merged
Merged
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
mention-bot
commented
Jan 23, 2017
@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @skjnldsv to be a potential reviewer. |
eppfel
previously requested changes
Jan 23, 2017
eppfel
left a comment
Member
There was a problem hiding this comment.
I would like to discuss this first, so I will bock this for now.
skjnldsv
previously requested changes
Jan 23, 2017
skjnldsv
left a comment
Member
There was a problem hiding this comment.
I disagree too! I think this was a great addition :/
Espina2
commented
Jan 23, 2017
Contributor
I agree with @jancborchardt that it should have consistency, but also agree with @eppfel and @skjnldsv that we should make some different to the buttons, but please not the 3D thing because this are not used anywhere. |
eppfel
dismissed
their stale reviewJanuary 23, 2017 18:01
This is just a minor change and there are enough objections.
icewind1991
approved these changes
Jan 24, 2017
skjnldsv
dismissed
their stale reviewJanuary 24, 2017 16:10
@jancborchardt made his point. Let's merge this.
MorrisJobke
approved these changes
Jan 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix#3203 (Shadow for buttons look strange & off-style)
This fixes the style to look consistent with Nextcloud style. cc @nextcloud/designers
Before:
After:
