Skip to content

Optimize autoloader level 2 - #32044

Closed
CarlSchwan wants to merge 1 commit into
masterfrom
performance/optimize-autoloader
Closed

Optimize autoloader level 2#32044
CarlSchwan wants to merge 1 commit into
masterfrom
performance/optimize-autoloader

Conversation

@CarlSchwan

Copy link
Copy Markdown
Member

This is using the APCu cache approache since because we load dynamically
other apps that don't include a composer autoloader file the authoritative
class maps approach is not possible.

See
https://getcomposer.org/doc/articles/autoloader-optimization.md#optimization-level-2-b-apcu-cache

Test plan:

  1. Enable it
  2. Browse a few pages, nothing unusual happens

This is using the APCu cache approache since because we load dynamically
other apps that don't include a composer autoloader file the authoritative
class maps approach is not possible.
See
https://getcomposer.org/doc/articles/autoloader-optimization.md#optimization-level-2-b-apcu-cache
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
CarlSchwan requested a review from a teamApril 21, 2022 13:04
@CarlSchwanCarlSchwan self-assigned this Apr 21, 2022
@CarlSchwan
CarlSchwan requested review from PVince81, come-nc and skjnldsv and removed request for a teamApril 21, 2022 13:04
@kesselb

Copy link
Copy Markdown
Contributor

Please check #11290 / #11292

@CarlSchwan

Copy link
Copy Markdown
MemberAuthor

Please check #11290 / #11292

Thanks for the links, i guess if this was a so easy fix someone else would have already done it. I will see if I can fix it otherwise I will close this Pr

@kesselb

kesselb commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

Thanks for the links, i guess if this was a so easy fix someone else would have already done it.

Hmm. Also possible that everyone just forget about it ;) To invalidate the apcu cache properly some identifier is needed that changes when server and/or apps are updated.

@CarlSchwan

Copy link
Copy Markdown
MemberAuthor

Thanks for the links, i guess if this was a so easy fix someone else would have already done it.

Hmm. Also possible that everyone just forget about it ;) To invalidate the apcu cache properly some identifier is needed that changes when server and/or apps are updated.

Alternatively we could also clear the apcu cache after an update or an app is enabled/disabled

@come-nc
come-nc removed their request for review May 5, 2022 15:09
@come-nccome-nc added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 5, 2022
@skjnldsv
skjnldsv deleted the performance/optimize-autoloader branch March 14, 2024 07:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@CarlSchwan@kesselb@come-nc