Skip to content

use and cache root storage info if a share can't be resolved - #32076

Merged
CarlSchwan merged 2 commits into
masterfrom
cache-storage-info-failed-share
Apr 22, 2022
Merged

use and cache root storage info if a share can't be resolved#32076
CarlSchwan merged 2 commits into
masterfrom
cache-storage-info-failed-share

Conversation

@icewind1991

@icewind1991icewind1991 commented Apr 22, 2022

Copy link
Copy Markdown
Member

as is a broken share will never be cached

Follow up from #32048

@icewind1991icewind1991 added this to the Nextcloud 25 milestone Apr 22, 2022
@blizzz

blizzz commented Apr 22, 2022

Copy link
Copy Markdown
Member

/backport to stable24

@icewind1991icewind1991 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 22, 2022
@icewind1991

icewind1991 commented Apr 22, 2022

Copy link
Copy Markdown
MemberAuthor

This might need some more work

@icewind1991
use and cache root storage info if a share can't be resolved
e50d78e
as is a broken share will never be cached
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
add logging of failed quota info
54ac585
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the cache-storage-info-failed-share branch from cd6ff04 to 54ac585CompareApril 22, 2022 13:29
@icewind1991icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 22, 2022
@CarlSchwan

CarlSchwan commented Apr 22, 2022

Copy link
Copy Markdown
Member

Ci failure is unrelated (also saw it on other recent PRs)

@CarlSchwan
CarlSchwan merged commit b7be8f5 into masterApr 22, 2022
@CarlSchwan
CarlSchwan deleted the cache-storage-info-failed-share branch April 22, 2022 19:26
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 22, 2022
Merged
icewind1991 added a commit that referenced this pull request May 11, 2022
@icewind1991
don't unjail the path when getting the storage info
5e08bbc
the original reason for adding it no longer exist.
This was added with #30985 since then the share source storage was also used, however this was changed with #32076
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991 added a commit that referenced this pull request May 11, 2022
@icewind1991
don't unjail the path when getting the storage info
643ef06
the original reason for adding it no longer exist.
This was added with #30985 since then the share source storage was also used, however this was changed with #32076
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 mentioned this pull request May 11, 2022
Merged
backportbot-nextcloudBot pushed a commit that referenced this pull request May 12, 2022
@icewind1991@backportbot-nextcloud
don't unjail the path when getting the storage info
cc4aab1
the original reason for adding it no longer exist.
This was added with #30985 since then the share source storage was also used, however this was changed with #32076
Signed-off-by: Robin Appelman <robin@icewind.nl>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzzblizzzblizzz approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsperformance 🚀

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@blizzz@CarlSchwan