Skip to content

Include more emoji chars to test and fixes after include it - #32220

Merged
nickvergessen merged 1 commit into
masterfrom
feature/add-tests-to-validate-emojis
May 3, 2022
Merged

Include more emoji chars to test and fixes after include it#32220
nickvergessen merged 1 commit into
masterfrom
feature/add-tests-to-validate-emojis

Conversation

@vitormattos

@vitormattosvitormattos commented Apr 29, 2022•
edited
Loading

Copy link
Copy Markdown

Scenario before:
tests breaking with specific emojis

Scenario after:
All emoji used in emoji picker working fine.

@vitormattos
Include more emoji chars to test and fixes after include it
cefcd55
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattosvitormattos added the 3. to review Waiting for reviews label Apr 29, 2022
@vitormattosvitormattos added this to the Nextcloud 25 milestone Apr 29, 2022
@vitormattosvitormattos self-assigned this Apr 29, 2022
@vitormattosvitormattos mentioned this pull request May 2, 2022
Closed
@vitormattos

vitormattos commented May 3, 2022

Copy link
Copy Markdown
Author

The broken scenarios don't have relation with this PR:

src/tests/acceptance/features/app-files-sharing.feature:23
src/tests/acceptance/features/app-files-sharing.feature:266
src/tests/acceptance/features/app-files-sharing.feature:291

@nickvergessen
nickvergessen merged commit 290697b into masterMay 3, 2022
@nickvergessen
nickvergessen deleted the feature/add-tests-to-validate-emojis branch May 3, 2022 14:08
@vitormattosvitormattos mentioned this pull request May 3, 2022
Merged
@vitormattosvitormattos mentioned this pull request May 16, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes

Assignees

@vitormattosvitormattos

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

3 participants

@vitormattos@nickvergessen@CarlSchwan