Skip to content

Support theme meta w3c standard - #32231

Merged
skjnldsv merged 1 commit into
masterfrom
feat/theming-scheme-meta
Feb 7, 2024
Merged

Support theme meta w3c standard#32231
skjnldsv merged 1 commit into
masterfrom
feat/theming-scheme-meta

Conversation

@skjnldsv

@skjnldsvskjnldsv commented May 1, 2022•
edited
Loading

Copy link
Copy Markdown
Member

@skjnldsvskjnldsv added this to the Nextcloud 25 milestone May 1, 2022
@skjnldsv
skjnldsv requested a review from a teamMay 1, 2022 10:14
@skjnldsvskjnldsv self-assigned this May 1, 2022
@skjnldsv
skjnldsv requested review from PVince81, artonge, szaimen and vanpertsch and removed request for a teamMay 1, 2022 10:14
@szaimen

This comment was marked as resolved.

Sign in to view
@skjnldsv

This comment was marked as resolved.

Sign in to view
@szaimen

szaimen commented May 1, 2022

Copy link
Copy Markdown
Contributor

That's not related to this pr, is it?

Not really, no. Could be done in a follow-up I suppose...
image
image

@skjnldsv

skjnldsv commented May 1, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

That's not related to this pr, is it?

Not really, no. Could be done in a follow-up I suppose... imageimage

Ah! But it's also kinda related to the feature, sorry I misunderstood :)
I'll see that after the weekend 🙈

CarlSchwan
CarlSchwan approved these changes May 2, 2022
View reviewed changes

@CarlSchwanCarlSchwan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature :)

Comment threadapps/theming/lib/ITheme.php Outdated
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@blizzzblizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
Merged
github-advanced-security[bot]
github-advanced-securityAI found potential problems Apr 11, 2023
View reviewed changes
Comment threadapps/theming/lib/ITheme.php Fixed
Comment threadapps/theming/lib/Service/ThemeInjectionService.php Fixed
Comment threadapps/theming/lib/Service/ThemeInjectionService.php Fixed
@szaimen
szaimen requested review from a team and Pytal and removed request for a team, szaimen and vanpertschApril 13, 2023 10:44
@szaimenszaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 13, 2023
@skjnldsvskjnldsv mentioned this pull request May 3, 2023
Merged
@szaimenszaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 16, 2023
@skjnldsvskjnldsv removed this from the Nextcloud 28 milestone Sep 2, 2023
@skjnldsv
skjnldsvforce-pushed the feat/theming-scheme-meta branch 3 times, most recently from d0cf244 to 4e2b616CompareFebruary 7, 2024 11:29
@skjnldsvskjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Feb 7, 2024
@skjnldsvskjnldsv added this to the Nextcloud 29 milestone Feb 7, 2024
@skjnldsvskjnldsv removed the 2. developing Work in progress label Feb 7, 2024
github-advanced-security[bot]
github-advanced-securityAI found potential problems Feb 7, 2024
View reviewed changes
Comment threadapps/theming/lib/ITheme.php Fixed
@skjnldsv
skjnldsvforce-pushed the feat/theming-scheme-meta branch from 4e2b616 to 9c9579aCompareFebruary 7, 2024 15:58
@skjnldsv
Support theme meta w3c standard
775974f
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: Simon L <szaimen@e.mail.de>
@skjnldsv
skjnldsvforce-pushed the feat/theming-scheme-meta branch from 9c9579a to 775974fCompareFebruary 7, 2024 16:36
@skjnldsv
skjnldsv enabled auto-merge February 7, 2024 17:12
@skjnldsv
skjnldsv merged commit 566586c into masterFeb 7, 2024
@skjnldsv
skjnldsv deleted the feat/theming-scheme-meta branch February 7, 2024 17:20
artonge pushed a commit that referenced this pull request Feb 8, 2024
@skjnldsv@artonge
Merge pull request#32231from nextcloud/feat/theming-scheme-meta
6364e53
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
@ShGKme

ShGKme commented Mar 7, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR changes focus-visible styles for me.

image

I have a dark system theme and a light Nextcloud theme. With this PR, I have

<metaname="color-scheme" content="light dark">

Is light dark an expected value? Why dark if I have the light theme?

With light - outline is the same as it was before this PR:

image

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@PVince81PVince81Awaiting requested review from PVince81
@PytalPytalAwaiting requested review from PytalPytal was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: theming

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

7 participants

@skjnldsv@szaimen@ShGKme@artonge@CarlSchwan@github-advanced-security@blizzz