Uh oh!
There was an error while loading. Please reload this page.
Fix logging data context to file - #32242
Merged
Merged
Conversation
tcitworld
requested review from
a team, CarlSchwan, ChristophWurst, icewind1991 and juliusknorr
and removed request for
a teamMay 2, 2022 15:54
tcitworldforce-pushed
the
fix-logging-data-array
branch
from
May 2, 2022 15:55
adef8fb to
67ad2cfComparetcitworldforce-pushed
the
fix-logging-data-array
branch
from
May 2, 2022 16:30
67ad2cf to
613f608CompareIt was only logged when an exception was provided or when using logData (which is not being much used). We make sure the interpolated parameters are not logged. Only tested with file write logger, but shouldn't work differently. Crash reporters always had the context. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworldforce-pushed
the
fix-logging-data-array
branch
from
May 2, 2022 17:30
613f608 to
1e7d924Comparecome-nc
approved these changes
May 16, 2022
tcitworld
commented
Jun 21, 2022
MemberAuthor
Backports ? |
blizzz
commented
Jun 22, 2022
Member
imo it's rather an enhancement than a fix? |
tcitworld
commented
Jun 22, 2022
MemberAuthor
It was the behaviour before the switch to PSR's LoggerInterface IIRC, far from being important anyway indeed. |
blizzz
commented
Jun 22, 2022
Member
didn't recall. Nothing older than yesterday's release 🤷 Well, then it is a regression indeed, and backporting would be legit. |
blizzz
commented
Jun 22, 2022
Member
/backport to stable24 |
blizzz
commented
Jun 22, 2022
Member
/backport to stable23 |
blizzz
commented
Jun 22, 2022
Member
/backport to stable22 |
This was referenced Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was only logged when an exception was provided or when using
logData(which is not being much used btw).We make sure only the parameters that weren't interpolated are logged.
Only tested with file write logger, but other writers shouldn't work differently.
Crash reporters always had the context.