Skip to content

Use getLocale and getLanguage from @nc-l10n - #32257

Closed
artonge wants to merge 1 commit into
masterfrom
feat/use_nc_l10n
Closed

Use getLocale and getLanguage from @nc-l10n#32257
artonge wants to merge 1 commit into
masterfrom
feat/use_nc_l10n

Conversation

@artonge

@artongeartonge commented May 3, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR make sure that the logic is not duplicated.

To merge when nextcloud-libraries/nextcloud-l10n#434 is released

⚠️ Let's wait until @nextcloud/dialogs and @nextcloud/moment update @nextcloud/l10n to reduce the amount of warnings.

@artongeartonge added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 dependencies labels May 3, 2022
@artongeartonge added this to the Nextcloud 25 milestone May 3, 2022
@artongeartonge self-assigned this May 3, 2022
@artongeartonge mentioned this pull request May 3, 2022
Merged
@ChristophWurstChristophWurst added the pending documentation This pull request needs an associated documentation update label May 4, 2022
@artonge
artongeforce-pushed the feat/use_nc_l10n branch from 098df9b to 207d71cCompareMay 4, 2022 09:25
tcitworld
tcitworld reviewed May 5, 2022
View reviewed changes

@tcitworldtcitworld left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting to add some context to the message

Comment threadcore/src/OC/l10n.js Outdated
Comment threadcore/src/OC/l10n.js Outdated
@artonge
artongeforce-pushed the feat/use_nc_l10n branch from 207d71c to b35fc69CompareMay 5, 2022 12:19
@artongeartonge changed the title Use getLocale and getLanguage from nc-l10nUse getLocale and getLanguage from @nc-l10nMay 5, 2022
@artonge
artonge requested review from a team, PVince81, Pytal and szaimen and removed request for a teamMay 10, 2022 16:29
@artonge
Use getLocale and getLanguage from nc-l10n
d5f9852
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artongeartonge added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 10, 2022
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@blizzzblizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzzblizzz mentioned this pull request Mar 7, 2023
Merged
@blizzzblizzz modified the milestones: Nextcloud 26, Nextcloud 27Mar 9, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
@blizzzblizzz mentioned this pull request May 17, 2023
Merged
@blizzzblizzz modified the milestones: Nextcloud 27, Nextcloud 28May 23, 2023
@artongeartonge closed this Sep 28, 2023
@skjnldsv
skjnldsv deleted the feat/use_nc_l10n branch March 14, 2024 07:45
@skjnldsvskjnldsv removed this from the Nextcloud 28 milestone Aug 14, 2024
@skjnldsvskjnldsv removed the pending documentation This pull request needs an associated documentation update label Mar 27, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tcitworldtcitworldtcitworld left review comments

Assignees

@artongeartonge

Labels

2. developingWork in progressdependenciestechnical debt🧱 🤔🚀

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@artonge@tcitworld@ChristophWurst@blizzz@skjnldsv