Skip to content

Remove useless dependency on SQLite (non-PDO) - #3246

Merged
MorrisJobke merged 1 commit into
masterfrom
fix-sqlite-dependency
Jan 26, 2017
Merged

Remove useless dependency on SQLite (non-PDO)#3246
MorrisJobke merged 1 commit into
masterfrom
fix-sqlite-dependency

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

cc @nickvergessen@LukasReschke@icewind1991@pmattern

I tested this and it still works (I disabled the PHP module sqlite3 ;))

@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Jan 24, 2017
@MorrisJobkeMorrisJobke added this to the Nextcloud 12.0 milestone Jan 24, 2017
@icewind1991

icewind1991 commented Jan 25, 2017

Copy link
Copy Markdown
Member

You need to update the tests for this

* we only require the PDO driver
* fixes#481
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

You need to update the tests for this

Fixed

@MorrisJobke
MorrisJobke merged commit e21170b into masterJan 26, 2017
@MorrisJobke
MorrisJobke deleted the fix-sqlite-dependency branch January 26, 2017 21:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQLite: Both PDO and vendor specific driver needed according to installation wizard and running instance

3 participants

@MorrisJobke@icewind1991@LukasReschke