Uh oh!
There was an error while loading. Please reload this page.
[stable24] Fix backgroundjobs mode - #32470
Merged
Merged
Conversation
CarlSchwan
approved these changes
May 18, 2022
kesselb
requested review from
a team, artonge, skjnldsv and szaimen
and removed request for
a teamMay 18, 2022 08:45
artonge
approved these changes
May 18, 2022
artonge
commented
May 18, 2022
Collaborator
/compile amend / |
nextcloud-commandforce-pushed
the
bug/noid/stable24-fix-backgroundjobs-mode
branch
from
May 18, 2022 12:16
ebf0079 to
096a21dCompareskjnldsv
commented
May 20, 2022
Member
Multiple failures |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselbforce-pushed
the
bug/noid/stable24-fix-backgroundjobs-mode
branch
from
May 20, 2022 12:25
096a21d to
575e853Comparekesselb
commented
May 20, 2022
ContributorAuthor
Thanks for notice. Rebased the branch to stable24 to pick up the latest changes. Let's hope this makes the CI happy 🤞 |
artonge
commented
May 30, 2022
Collaborator
CI failure unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#32610
Radio input's for background jobs mode (ajax, webcron, cron) do not work anymore for main and stable24.
Change event works but
$(_this).is(':checked')is always false. It's related to the arrow syntax and lexical this binding.Helpful reading: https://stackoverflow.com/questions/27670401/using-jquery-this-with-es6-arrow-functions-lexical-this-binding