Modernize the error handler

[ChristophWurst]

• Make it a dynamic class with dynamic methods
• Make the logger a constructor arg -> it is always available
• Fix that some deprecations were logged as errors (E_DEPRECATED vs E_USER_DEPRECATED)

[ChristophWurst]

/backport 96a91cb to stable24

[CarlSchwan]

Looks good, just need a cs:fix run

[ChristophWurst]

Tests fail

[ChristophWurst]

I've moved the handler registration outside the constructor to make the class testable.

code has changed

[come-nc]

👍

[come-nc]

@ChristophWurst Will tests still fail on deprecation warnings? We have convertDeprecationsToExceptions="true" in the phpunit configuration and it’s quite useful to ensure PHP compatibility.

[ChristophWurst]

@ChristophWurst Will tests still fail on deprecation warnings? We have convertDeprecationsToExceptions="true" in the phpunit configuration and it’s quite useful to ensure PHP compatibility.

Looks like they do

This attribute configures whether E_DEPRECATED and E_USER_DEPRECATED events triggered by the code under test are converted to an exception (and mark the test as error).

[backportbot-nextcloud]

The backport to stable24 failed. Please do this backport manually.

[ChristophWurst]

/backport 4c8ec6d to stable25