Uh oh!
There was an error while loading. Please reload this page.
[stable24] Fix share permissions rendering - #32674
Merged
Merged
Conversation
backportbot-nextcloudBot
requested review from
PVince81, Pytal, artonge and skjnldsvMay 31, 2022 16:42
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
artonge
commented
Jun 7, 2022
Collaborator
/compile amend / |
nextcloud-commandforce-pushed
the
backport/32670/stable24
branch
from
June 7, 2022 11:13
a0b8478 to
e700161Compareartonge
approved these changes
Jun 8, 2022
artonge
commented
Jun 8, 2022
Collaborator
CI failure unrelated |
Pytal
approved these changes
Jun 8, 2022
Pytal
commented
Jun 8, 2022
Member
@artonge failures look a bit different than usual, unrelated? |
Collaborator
First error about notification not coming (recurring issue):
Second error in the setting page (couldn't find the same behavior in other CI runs, let's rebase and see):
|
The `SHARE` permissions falls into the `default` case in the switch case, causing the rendering to look like ` , Upload, Read`. This PR changes the return value of the `default` case and adds a `filter` to remove those values. Signed-off-by: Louis Chemineau <louis@chmn.me> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
artongeforce-pushed
the
backport/32670/stable24
branch
from
June 9, 2022 13:07
e700161 to
8a2b70fCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #32670