Uh oh!
There was an error while loading. Please reload this page.
Fix email shares not being shown to other users - #32719
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
st3inyforce-pushed
the
fix/noid/email-shares-not-shown
branch
from
June 3, 2022 14:32
6d1f36f to
46f8090Comparest3iny
commented
Jun 3, 2022
MemberAuthor
/backport to stable24 |
st3iny
commented
Jun 3, 2022
MemberAuthor
/backport to stable23 |
st3iny
commented
Jun 3, 2022
MemberAuthor
/backport to stable22 |
st3iny
marked this pull request as ready for review
June 7, 2022 07:37
st3iny
requested review from
a team, ChristophWurst, come-nc, icewind1991 and skjnldsv
and removed request for
a teamJune 7, 2022 07:39
This comment was marked as resolved.
This comment was marked as resolved.
come-nc
reviewed
Jun 7, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
icewind1991
approved these changes
Jun 7, 2022
PVince81
commented
Jun 10, 2022
Member
@st3iny please squash |
st3inyforce-pushed
the
fix/noid/email-shares-not-shown
branch
from
June 10, 2022 13:26
49c380e to
2d8319dCompareCarlSchwan
approved these changes
Jun 10, 2022
PVince81
commented
Jun 13, 2022
Member
suspicious failure: |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3inyforce-pushed
the
fix/noid/email-shares-not-shown
branch
from
June 17, 2022 15:31
2d8319d to
c1f054aComparest3iny
commented
Jun 17, 2022
MemberAuthor
That seems like a false alarm. This error also exists in other drone runs. I rebased to latest master to fix the failing scenario. I ran the integration test locally and it did not fail after rebasing. |
st3iny
commented
Jun 24, 2022
MemberAuthor
/backport to stable23 |
st3iny
commented
Jun 24, 2022
MemberAuthor
/backport to stable22 |
This was referenced Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I adapted the logic from
server/lib/private/Share20/DefaultShareProvider.php
Lines 729 to 740 in 6d5d91f
How to reproduce?
Expected behaviour:
Share by mail is shown to other users in the same group. Sharing sub folders of groupfolders with users works like this too.
Current behaviour
Share is only shown to the admin who created the share.
Screenshots