Fix risky test without assertion

[nickvergessen]

Before:

There was 1 risky test:
1) Test\Files\Node\FolderTest::testGet
This test did not perform any assertions
/home/nickv/Nextcloud/25/server/tests/lib/Files/Node/FolderTest.php:95
phpvfscomposer:///home/nickv/Tools/vendor/phpunit/phpunit/phpunit:97
OK, but incomplete, skipped, or risky tests!
Tests: 64, Assertions: 144, Risky: 1.

[PVince81]

👍

[nickvergessen]

@PVince81 you added tests/lib/Encryption/UtilTest.php last week, but it doesn't work:

here were 7 errors:
1) Test\Encryption\UtilTest::testIsSystemWideMountPoint with data set #0 (false, 'non-matching mount point name', array(), array(), '/mp_another')
PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "OCA\Files_External\Lib\StorageConfig" does not exist
/home/nickv/Nextcloud/25/server/tests/lib/Encryption/UtilTest.php:221
phpvfscomposer:///home/nickv/Tools/vendor/phpunit/phpunit/phpunit:97
2) Test\Encryption\UtilTest::testIsSystemWideMountPoint with data set #1 (true, 'applicable to all', array(), array())
PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "OCA\Files_External\Lib\StorageConfig" does not exist
/home/nickv/Nextcloud/25/server/tests/lib/Encryption/UtilTest.php:221
phpvfscomposer:///home/nickv/Tools/vendor/phpunit/phpunit/phpunit:97
3) Test\Encryption\UtilTest::testIsSystemWideMountPoint with data set #2 (true, 'applicable to user directly', array('user1'), array())
PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "OCA\Files_External\Lib\StorageConfig" does not exist
/home/nickv/Nextcloud/25/server/tests/lib/Encryption/UtilTest.php:221
phpvfscomposer:///home/nickv/Tools/vendor/phpunit/phpunit/phpunit:97
4) Test\Encryption\UtilTest::testIsSystemWideMountPoint with data set #3 (true, 'applicable to group directly', array(), array('group1'))
PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "OCA\Files_External\Lib\StorageConfig" does not exist
/home/nickv/Nextcloud/25/server/tests/lib/Encryption/UtilTest.php:221
phpvfscomposer:///home/nickv/Tools/vendor/phpunit/phpunit/phpunit:97
5) Test\Encryption\UtilTest::testIsSystemWideMountPoint with data set #4 (false, 'non-applicable to current user', array('user2'), array())
PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "OCA\Files_External\Lib\StorageConfig" does not exist
/home/nickv/Nextcloud/25/server/tests/lib/Encryption/UtilTest.php:221
phpvfscomposer:///home/nickv/Tools/vendor/phpunit/phpunit/phpunit:97
6) Test\Encryption\UtilTest::testIsSystemWideMountPoint with data set #5 (false, 'non-applicable to current user's group', array(), array('group2'))
PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "OCA\Files_External\Lib\StorageConfig" does not exist
/home/nickv/Nextcloud/25/server/tests/lib/Encryption/UtilTest.php:221
phpvfscomposer:///home/nickv/Tools/vendor/phpunit/phpunit/phpunit:97
7) Test\Encryption\UtilTest::testIsSystemWideMountPoint with data set #6 (true, 'mount point without leading slash', array(), array(), 'mp')
PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "OCA\Files_External\Lib\StorageConfig" does not exist
/home/nickv/Nextcloud/25/server/tests/lib/Encryption/UtilTest.php:221
phpvfscomposer:///home/nickv/Tools/vendor/phpunit/phpunit/phpunit:97

Can you have a look?

[PVince81]

hmm, they worked for me locally but I had files_external enabled.

probably because we're using a class from an app that might not be enabled during test run, or only during specific order

I'll see if I can trigger enabling of the app in setUp, otherwise will need to do it in the test setups

[PVince81]

I didn't find code in core where the app would be enabled through tests, so I added it to "enable_apps.php": 6df0a79

turns out other apps like "encryption" is there too

let's see if the tests pass now on CI... they passed locally again for me until I disabled files_external

[PVince81]

looks like enabling files_external makes it worse as now tests are trying to run, I'll revert it for now.

will need another more targetted solution that doesn't require including the class

[PVince81]

here we go, all mocked: de93d17

not sure how long this PR will live, we might want to cherry pick some fixes into separate PRs ?

[come-nc]

Why for core class you went from string to ::class and for files-external classes you go the other way around?

[nickvergessen]

Because core classes are fine. This class might not be loaded as the test is in core and the app is not force enabled nor default enabled

[PVince81]

maybe some day... owncloud/core#25422