Uh oh!
There was an error while loading. Please reload this page.
[stable24] Temporary passwords fixes 31952 - #32764
Merged
Merged
Conversation
backportbot-nextcloudBot
requested review from
CarlSchwan, PVince81, Pytal, StCyr, artonge and skjnldsvJune 8, 2022 13:09
artonge
commented
Jun 8, 2022
Collaborator
/compile amend / |
…y passwords for mail shares: 1- Changes style of "forgot password?" and "Back" button 2- Adds information about share password's expiration time in the emails sent. 3- Shows password expiration time in the Share menu 4- Fixes an issue when the message "Password expires..." would be shown for non email share types (which don't have temporary passswords) 5- At share's creation, password should only be sent when it's a permanent one See also #31952 Signed-off-by: Cyrille Bollu <cyrpub@bollu.be> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
backport/31981/stable24
branch
from
June 8, 2022 13:22
fc9d845 to
e35cbd2Compareartonge
approved these changes
Jun 8, 2022
artonge
commented
Jun 9, 2022
Collaborator
CI failure unrelated |
PVince81
reviewed
Sep 1, 2022
| id="request-password-button-not-talk" | ||
| value="<?php p($l->t('Request password')); ?>" | ||
| class="primary" /> | ||
| <a id="request-password-button-not-talk"><?php p($l->t('Forgot password?')); ?></a> |
Member
There was a problem hiding this comment.
@StCyr any reason you reverted this ? I thought we wanted to keep the text "Request password" instead of "Forgot password"
maybe an oversight during conflict resolution ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #31981