Skip to content

Fix Uninitialized string offset 0 at GenerateMimetypeFileBuilder.php#39 - #32859

Merged
artonge merged 1 commit into
masterfrom
bug/31973/array-key-might-be-empty
Oct 11, 2022
Merged

Fix Uninitialized string offset 0 at GenerateMimetypeFileBuilder.php#39#32859
artonge merged 1 commit into
masterfrom
bug/31973/array-key-might-be-empty

Conversation

@kesselb

@kesselbkesselb commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

Fix#31973

Someone added a file config/mimetypealiases.json to my instance like below. Key is empty hence the check if the first character of the string is _ fails.

{
"": "x-office\/document",
"application\/vnd.openxmlformats-officedocument.wordprocessingml.document.docxf": "x-office\/document",
"application\/vnd.openxmlformats-officedocument.wordprocessingml.document.oform": "x-office\/document"
}

@kesselb
kesselbforce-pushed the bug/31973/array-key-might-be-empty branch from 3c09020 to 19a7c84CompareJune 13, 2022 10:03
@kesselbkesselb added bug 2. developing Work in progress labels Jun 13, 2022
@kesselbkesselb self-assigned this Jun 13, 2022
PVince81
PVince81 reviewed Jun 13, 2022
View reviewed changes
Comment threadcore/Command/Maintenance/Mimetype/GenerateMimetypeFileBuilder.php Outdated
@kesselb
kesselbforce-pushed the bug/31973/array-key-might-be-empty branch 2 times, most recently from 2eac3fd to d595013CompareJune 14, 2022 13:10
@kesselb
Fix Uninitialized string offset 0 at GenerateMimetypeFileBuilder.php#39
6f3ab2f
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the bug/31973/array-key-might-be-empty branch from d595013 to 6f3ab2fCompareJune 28, 2022 13:45
@kesselbkesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 28, 2022
come-nc
come-nc reviewed Jun 28, 2022
View reviewed changes
Comment threadcore/Command/Maintenance/Mimetype/GenerateMimetypeFileBuilder.php
@solracsfsolracsf added this to the Nextcloud 25 milestone Sep 24, 2022
@blizzzblizzz mentioned this pull request Sep 27, 2022
Merged
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 27, 2022
come-nc
come-nc approved these changes Sep 28, 2022
View reviewed changes

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected to have an empty string as a valid key is $aliases array though?

@kesselb

kesselb commented Oct 10, 2022

Copy link
Copy Markdown
ContributorAuthor

Is it expected to have an empty string as a valid key is $aliases array though?

I don't think so ;)

@artonge
artonge merged commit e4d3344 into masterOct 11, 2022
@artonge
artonge deleted the bug/31973/array-key-might-be-empty branch October 11, 2022 09:15
@come-nc

come-nc commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

/backport to stable25

@come-nc

come-nc commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

/backport to stable24

@come-nc

come-nc commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

/backport to stable23

@backportbot-nextcloud

backportbot-nextcloudBot commented Oct 11, 2022

Copy link
Copy Markdown

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Oct 11, 2022

Copy link
Copy Markdown

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Oct 11, 2022

Copy link
Copy Markdown

The backport to stable23 failed. Please do this backport manually.

@vitormattos

vitormattos commented Oct 25, 2022

Copy link
Copy Markdown

Hi @come-nc I found this error in an instance with version25.
Was the pull request with the backport made?

@come-nc

come-nc commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Hi @come-nc I found this error in an instance with version25. Was the pull request with the backport made?

No, I’m gonna retrigger the bot and backport by hand if needed.

@come-nc

come-nc commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

/backport to stable25

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Oct 25, 2022
Merged
@come-nc

come-nc commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

/backport to stable24

@come-nc

come-nc commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

/backport to stable23

This was referenced Oct 25, 2022
Merged
Merged
@come-nc

come-nc commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Hi @come-nc I found this error in an instance with version25. Was the pull request with the backport made?

Merged in 25/24/23 now.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@come-nccome-nccome-nc approved these changes
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan
@PVince81PVince81Awaiting requested review from PVince81

Assignees

@kesselbkesselb

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

[Bug]: Error: Uninitialized string offset 0 at /nextcloud/core/Command/Maintenance/Mimetype/GenerateMimetypeFileBuilder.php#39

7 participants

@kesselb@come-nc@vitormattos@PVince81@artonge@blizzz@solracsf