Uh oh!
There was an error while loading. Please reload this page.
[stable23] Fix logger overwriting vars in some circumstances - #32906
Merged
Conversation
backportbot-nextcloudBot
requested review from
CarlSchwan, ChristophWurst, blizzz, come-nc, icewind1991, mgallien, miaulalala and skjnldsvJune 16, 2022 18:54
blizzz
approved these changes
Jun 16, 2022
skjnldsv
approved these changes
Jun 17, 2022
This was referenced Jun 17, 2022
Closed
Merged
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzzforce-pushed
the
backport/32898/stable23
branch
from
June 17, 2022 12:53
508f174 to
813a14aCompareblizzz
commented
Jun 17, 2022
Member
It was only the property type in the test class i had to remove for 7.3. |
blizzz
approved these changes
Jun 17, 2022
blizzz
commented
Jun 17, 2022
Member
This receives a merge exception during RC stage, because it is low risk, but fixes a phenomenon that may overwrite variables only because of logging an exception, that can have consequences on the paths further down. At least two issues are known and fixed by this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #32898