Deprecated ILogger from IJob by CarlSchwan · Pull Request #33047 · nextcloud/server

CarlSchwan · 2022-06-28T10:10:26Z

Since the ILogger will be soon removed we need to ensure that nothing in
the public API use it.

Add start to replace execute but without ILogger
execute still exists but only call start internally
Use more OCP interface for background job
Fix a lot of warning in tests related to background jobs

 $this->logger->error(
-'remote server "' . $target . '"" does not return a valid shared secret. Received data: ' . $body,
-['app' => 'federation']
+ 'remote server "' . $target . '"" does not return a valid shared secret. Received data: ' . $body,


come-nc · 2022-06-28T14:55:09Z

❤️

ChristophWurst · 2022-06-29T12:42:46Z

Since the ILogger will be soon

It will? 🎉

ChristophWurst

Lots of good cleanup

Personally I would prefer if the PR only touched the logger aspects if that is what title and subscription say. E.g. background job OC to OCP kinda feels sneaked in.

But I understand it's easier this way, so 👍 and 🤞

CarlSchwan · 2022-06-29T12:59:29Z

Since the ILogger will be soon
It will? tada

still one year to wait since we need to wait 3 years after it has been deprecated, but since execute(...., ILogger) was for some app the only reasons why ILogger was still used, this should make it easier to get rid of it as soon as the 3 years are over.

github-actions · 2022-07-14T13:35:40Z

Possible performance regression detected

Show Output

1 queries added
= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
+ UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

github-actions · 2022-07-28T12:51:41Z

Possible performance regression detected

Show Output

2 queries added
= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
≠ /remote.php/dav/files/test/many_files with 1 queries added
+ UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
+ UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt

come-nc · 2022-07-28T15:18:44Z

PHP Fatal error: Cannot use OCP\Files\SimpleFS\ISimpleFile as ISimpleFile because the name is already in use in /home/runner/work/server/server/tests/Core/Controller/AvatarControllerTest.php on line 42

Since the ILogger will be soon removed we need to ensure that nothing in the public api use it. Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

CarlSchwan · 2022-08-23T14:55:38Z

ci failure unrelated

CarlSchwan added the 3. to review Waiting for reviews label Jun 28, 2022

CarlSchwan added this to the Nextcloud 25 milestone Jun 28, 2022

CarlSchwan requested a review from come-nc June 28, 2022 10:10

CarlSchwan self-assigned this Jun 28, 2022

github-advanced-securityAI found potential problems Jun 28, 2022
View reviewed changes

Comment threadlib/public/BackgroundJob/Job.php Fixed

github-advanced-securityAI found potential problems Jun 28, 2022
View reviewed changes

CarlSchwan force-pushed the fix/ijob-logger-deprecated branch from 7d91d1d to 73b41e8Compare June 28, 2022 11:45

come-nc reviewed Jun 28, 2022
View reviewed changes

Comment threadlib/public/BackgroundJob/QueuedJob.php Outdated

CarlSchwan force-pushed the fix/ijob-logger-deprecated branch 3 times, most recently from 6721a06 to b700c8bCompare June 29, 2022 12:40

CarlSchwan requested review from ChristophWurst and kesselb June 29, 2022 12:40

ChristophWurst approved these changes Jun 29, 2022
View reviewed changes

CarlSchwan force-pushed the fix/ijob-logger-deprecated branch from b700c8b to f512492Compare June 29, 2022 13:02

github-advanced-securityAI found potential problems Jun 29, 2022
View reviewed changes

Comment threadapps/federation/lib/BackgroundJob/GetSharedSecret.php Fixed

CarlSchwan force-pushed the fix/ijob-logger-deprecated branch from f512492 to dcbc9d1Compare June 29, 2022 13:12

CarlSchwan force-pushed the fix/ijob-logger-deprecated branch 3 times, most recently from af33a00 to 3c7280aCompare July 14, 2022 13:31

CarlSchwan force-pushed the fix/ijob-logger-deprecated branch 5 times, most recently from 6fa90dd to 06e1aa9Compare July 14, 2022 15:34

PVince81 requested a review from icewind1991 July 19, 2022 08:58

PVince81 requested a review from nickvergessen July 19, 2022 08:58

nickvergessen reviewed Jul 20, 2022
View reviewed changes

Comment threadapps/files_versions/lib/BackgroundJob/ExpireVersions.php
Comment threadlib/private/BackgroundJob/Legacy/QueuedJob.php Outdated
Comment threadlib/private/BackgroundJob/Legacy/RegularJob.php Outdated
Comment threadlib/private/Command/CallableJob.php Outdated

CarlSchwan force-pushed the fix/ijob-logger-deprecated branch from d24ef26 to 2d025a3Compare July 28, 2022 12:31

CarlSchwan requested review from come-nc and nickvergessen July 28, 2022 12:32

CarlSchwan force-pushed the fix/ijob-logger-deprecated branch from 2d025a3 to d03bb36Compare July 28, 2022 13:12

come-nc approved these changes Jul 28, 2022
View reviewed changes

CarlSchwan force-pushed the fix/ijob-logger-deprecated branch 2 times, most recently from 0fead00 to 5d02024Compare July 29, 2022 09:37

nickvergessen reviewed Jul 29, 2022
View reviewed changes

Comment threadtests/Core/Controller/AvatarControllerTest.php Outdated

CarlSchwan force-pushed the fix/ijob-logger-deprecated branch 2 times, most recently from b56a561 to f60c1a3Compare July 29, 2022 15:06

CarlSchwan added 3 commits August 8, 2022 17:03

Deprecated ILogger from IJob
19a2d6f
Since the ILogger will be soon removed we need to ensure that nothing in the public api use it. Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Port existing server code to new interface
48d9c4d
Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Fix many tests and warnings
49334e4
Signed-off-by: Carl Schwan <carl@carlschwan.eu>

CarlSchwan force-pushed the fix/ijob-logger-deprecated branch from f60c1a3 to 49334e4Compare August 8, 2022 15:04

This was referenced Aug 12, 2022
25.0.0 beta 1 #33505
Merged
25.0.0 beta 2 #33592
Merged

CarlSchwan merged commit b888c61 into masterAug 23, 2022

CarlSchwan deleted the fix/ijob-logger-deprecated branch August 23, 2022 14:55

blizzz mentioned this pull request Aug 24, 2022
25.0.0 beta 3 #33674
Merged

joshtrichards mentioned this pull request Sep 2, 2023
Move core apps backgroudjobs to OCP #13255
Open

Uh oh!

Uh oh!

Conversation

CarlSchwan commented Jun 28, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check notice

Uh oh!

come-nc commented Jun 28, 2022

Uh oh!

ChristophWurst commented Jun 29, 2022

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

CarlSchwan commented Jun 29, 2022

Uh oh!

Uh oh!

github-actionsBot commented Jul 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Jul 28, 2022

Uh oh!

come-nc commented Jul 28, 2022

Uh oh!

Uh oh!

CarlSchwan commented Aug 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CarlSchwan commented Jun 28, 2022•
edited
Loading