Uh oh!
There was an error while loading. Please reload this page.
[stable22] Check whether entry is of type ICacheEntry in Cache->remove() - #33060
Merged
Conversation
backportbot-nextcloudBot
requested review from
CarlSchwan, PVince81, icewind1991, kesselb and mejo-June 29, 2022 12:25
mejo-
approved these changes
Jun 29, 2022
CarlSchwan
approved these changes
Jun 29, 2022
kesselb
approved these changes
Jun 29, 2022
mejo-
commented
Jun 30, 2022
Member
/rebase |
In some scenarios (file not in cache, but partial data of it in the object), Cache->get() might return an array, which leads to errors like "Call to a member function getId() on array". So check whether the returned entry is of type ICacheEntry before doing operations on it in Cache->remove(). Fixes: #33023 Signed-off-by: Jonas <jonas@freesources.org>
nextcloud-commandforce-pushed
the
backport/33050/stable22
branch
from
June 30, 2022 12:24
c30fa1b to
3fbd7a6Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #33050