Skip to content

Paths added to messages and message cleanup - #33061

Merged
come-nc merged 5 commits into
nextcloud:masterfrom
ibpl:master-IB#1121253
Mar 14, 2023
Merged

Paths added to messages and message cleanup#33061
come-nc merged 5 commits into
nextcloud:masterfrom
ibpl:master-IB#1121253

Conversation

@pboguslawski

@pboguslawskipboguslawski commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

This mod adds path to error messages. Without it it's difficult for example
to find what path causes permission problems.

Related: https://help.nextcloud.com/t/ocp-files-notpermittedexception-could-not-create-folder/133818
Related: https://help.nextcloud.com/t/could-not-create-folder-false-error/65962/
Author-Change-Id: IB#1121253

CarlSchwan
CarlSchwan approved these changes Jun 29, 2022
View reviewed changes

@CarlSchwanCarlSchwan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me, thanks!

@CarlSchwan
CarlSchwan requested review from a team, ArtificialOwl, PVince81 and come-nc and removed request for a teamJune 29, 2022 12:45
@CarlSchwanCarlSchwan added the 3. to review Waiting for reviews label Jun 29, 2022
@CarlSchwanCarlSchwan added this to the Nextcloud 25 milestone Jun 29, 2022
@CarlSchwan

CarlSchwan commented Jun 29, 2022

Copy link
Copy Markdown
Member

Please fix the dco :) https://github.com/nextcloud/server/pull/33061/checks?check_run_id=7112172877

@pboguslawskipboguslawski mentioned this pull request Jun 29, 2022
Closed
8 tasks
@kesselb
kesselb changed the base branch from stable24 to masterJune 30, 2022 17:46
@kesselb
kesselb changed the base branch from master to stable24June 30, 2022 17:46
kesselb
kesselb previously requested changes Jun 30, 2022
View reviewed changes

@kesselbkesselb left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your pull request 👍

Please rebase this branch to master. Our usual process here is that every change goes to master and is backported (usually by a bot) if necessary.

@kesselb

kesselb commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

image

Sorry! Changing the base branch requested you as reviewer 🙈

@pboguslawski

pboguslawski commented Jul 1, 2022

Copy link
Copy Markdown
ContributorAuthor

Just force pushed this branch with commit fcb4943; this commit was created from master and DCO is present now - please change target branch of this PR from stable24 to master.

@kesselb
kesselb changed the base branch from stable24 to masterJuly 1, 2022 10:24
@kesselb
kesselb dismissed their stale reviewJuly 1, 2022 10:25

target branch is now master

PVince81
PVince81 reviewed Jul 27, 2022
View reviewed changes
Comment threadlib/private/Files/Node/Folder.php
PVince81
PVince81 reviewed Jul 27, 2022
View reviewed changes
Comment threadlib/private/Files/Node/Folder.php
@PVince81

PVince81 commented Jul 29, 2022

Copy link
Copy Markdown
Member

@pboguslawski do you might also adding a signed-off clause as per https://github.com/nextcloud/server/pull/33061/checks?check_run_id=7544272332 ? the DCO part is also stated in https://github.com/nextcloud/server/blob/master/contribute/HowToApplyALicense.md

@pboguslawski
Update Folder.php
a850424
Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
@pboguslawski

pboguslawski commented Jul 29, 2022

Copy link
Copy Markdown
ContributorAuthor

DCO fixed.

This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@ChristophWurst

ChristophWurst commented Oct 17, 2022

Copy link
Copy Markdown
Member

Unsure if failing CI is related or not. Could you please rebase to the latest master to have another clean CI run?

@pboguslawski

pboguslawski commented Nov 4, 2022

Copy link
Copy Markdown
ContributorAuthor

Current master merged to this PR.

@ChristophWurst

ChristophWurst commented Jan 12, 2023

Copy link
Copy Markdown
Member

Failing CI unrelated

@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 12, 2023
@come-nc

come-nc commented Jan 24, 2023

Copy link
Copy Markdown
Contributor

/rebase

@blizzzblizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzzblizzz mentioned this pull request Mar 7, 2023
Merged
@blizzzblizzz modified the milestones: Nextcloud 26, Nextcloud 27Mar 9, 2023
@come-nc
come-nc merged commit 9c3e06c into nextcloud:masterMar 14, 2023
@pboguslawski
pboguslawski deleted the master-IB#1121253 branch March 17, 2023 07:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81PVince81PVince81 left review comments
@tcitworldtcitworldtcitworld left review comments
@ChristophWurstChristophWurstChristophWurst approved these changes
@miaulalalamiaulalalamiaulalala approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@come-nccome-nccome-nc approved these changes
@kesselbkesselbkesselb left review comments
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwl

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

9 participants

@pboguslawski@CarlSchwan@kesselb@PVince81@ChristophWurst@come-nc@tcitworld@miaulalala@blizzz