Skip to content

Talk federation authentication - #33105

Merged
nickvergessen merged 1 commit into
masterfrom
feature/noid/talk-federation-auth
Oct 9, 2023
Merged

Talk federation authentication#33105
nickvergessen merged 1 commit into
masterfrom
feature/noid/talk-federation-auth

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jul 4, 2022•
edited
Loading

Copy link
Copy Markdown
Member

@nickvergessennickvergessen added the 2. developing Work in progress label Jul 4, 2022
@nickvergessennickvergessen self-assigned this Jul 4, 2022
@nickvergessennickvergessen added this to the Nextcloud 25 milestone Jul 4, 2022
@nickvergessennickvergessen mentioned this pull request Jul 4, 2022
Merged
1 task
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@blizzzblizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzzblizzz mentioned this pull request Mar 7, 2023
Merged
@nickvergessen
nickvergessenforce-pushed the feature/noid/talk-federation-auth branch from b04d4bf to 4ec3890CompareMarch 10, 2023 14:23
@skjnldsvskjnldsv mentioned this pull request May 3, 2023
Merged
@nickvergessen
nickvergessenforce-pushed the feature/noid/talk-federation-auth branch from 4ec3890 to ef1298aCompareOctober 9, 2023 08:25
@nickvergessennickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 9, 2023
@nickvergessen
nickvergessen marked this pull request as ready for review October 9, 2023 12:29
@bigcat88

bigcat88 commented Oct 9, 2023

Copy link
Copy Markdown
Member

Am I correct, this PR implements skip of the auth for the requests with X-Nextcloud-Federation header and authentication will be done by Talk?

@nickvergessen

nickvergessen commented Oct 9, 2023

Copy link
Copy Markdown
MemberAuthor

Am I correct, this PR implements skip of the auth for the requests with X-Nextcloud-Federation header and authentication will be done by Talk?

Exactly, because those federated users are not a user backend.

juliusknorr
juliusknorr approved these changes Oct 9, 2023
View reviewed changes

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Any specific reason to not just add it as an early return within handleLogin?

@nickvergessen
Talk federation authentication
7998afe
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

nickvergessen commented Oct 9, 2023

Copy link
Copy Markdown
MemberAuthor

Any specific reason to not just add it as an early return within handleLogin?

No, sounds actually more save, let me do that.

@nickvergessen
nickvergessenforce-pushed the feature/noid/talk-federation-auth branch from ef1298a to 7998afeCompareOctober 9, 2023 13:46
@nickvergessen
nickvergessen merged commit ab15cff into masterOct 9, 2023
@nickvergessen
nickvergessen deleted the feature/noid/talk-federation-auth branch October 9, 2023 15:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorrjuliusknorrjuliusknorr approved these changes
@bigcat88bigcat88bigcat88 approved these changes
@SystemKeeperSystemKeeperAwaiting requested review from SystemKeeper

Assignees

@nickvergessennickvergessen

Labels

3. to reviewWaiting for reviewsfeature: authenticationfeature: federation

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@bigcat88@juliusknorr@blizzz