Uh oh!
There was an error while loading. Please reload this page.
Update expire_date column of table comments - #33106
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Merged
Merged
Merged
Merged
marcelklehr
commented
Apr 26, 2023
Member
Ahoy! What's the status on this? Why is this needed? |
vitormattos
commented
Apr 26, 2023
Author
The Talk app started to use this column but we didn't implemented the update feature to change the expire date of a specific comment. I think that we can close this PR and don't merge. What you think @nickvergessen ? |
nickvergessen
commented
Apr 26, 2023
Member
We should fix it, as talk is not the only thing using comments and the API should work for all things. |
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattosforce-pushed
the
feature/update-expire-date
branch
from
April 26, 2023 16:22
57a7d5c to
5ed6722Comparenickvergessen
approved these changes
Apr 27, 2023
nickvergessen
commented
Apr 27, 2023
Member
/backport to stable26 |
nickvergessen
commented
Apr 27, 2023
Member
/backport to stable25 |
vitormattos
commented
May 2, 2023
Author
Description updated. |
Pytal
approved these changes
May 3, 2023
This was referenced May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Talk app started to use this column but we didn't implemented the update feature to change the expire date of a specific comment.
We need to have this at server side, as talk is not the only thing using comments and the API should work for all things.