Skip to content

Consolidate account property getters - #33206

Merged
PVince81 merged 1 commit into
masterfrom
enh/27869/consolidate
Jul 26, 2022
Merged

Consolidate account property getters#33206
PVince81 merged 1 commit into
masterfrom
enh/27869/consolidate

Conversation

@Pytal

@PytalPytal commented Jul 12, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Share logic for getting account properties to reduce repetition required for further accessibility improvements e.g. propagation of #33163 to all properties

@PytalPytal added this to the Nextcloud 25 milestone Jul 12, 2022
@PytalPytal self-assigned this Jul 12, 2022
@Pytal
Pytalforce-pushed the enh/27869/consolidate branch from 612c24b to 64584efCompareJuly 12, 2022 00:04
@PytalPytal mentioned this pull request Jul 12, 2022
Closed
11 tasks
@PVince81

PVince81 commented Jul 13, 2022

Copy link
Copy Markdown
Member

why is this needed ? a short explanation would be nice

@Pytal

Pytal commented Jul 13, 2022

Copy link
Copy Markdown
MemberAuthor

why is this needed ? a short explanation would be nice

Description updated

PVince81
PVince81 approved these changes Jul 14, 2022
View reviewed changes

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@Pytal
Pytalforce-pushed the enh/27869/consolidate branch 2 times, most recently from a70eb01 to ae18cddCompareJuly 15, 2022 19:15
@github-actions

github-actionsBot commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

Possible performance regression detected

Show Output
1 queries added
= /remote.php/dav/files/test
≠ /remote.php/dav/files/test/test.txt with 1 queries added
+ UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/many_files with 1 queries removed
- UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
+ UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

@PytalPytal mentioned this pull request Jul 15, 2022
Merged
1 task
@Pytal

Pytal commented Jul 15, 2022

Copy link
Copy Markdown
MemberAuthor

Review ping @reviewers

@github-actions

github-actionsBot commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

Possible performance regression detected

Show Output
1 queries added
= /remote.php/dav/files/test
≠ /remote.php/dav/files/test/test.txt with 1 queries added
+ UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/many_files with 1 queries removed
- UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
+ UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

@Pytal

Pytal commented Jul 21, 2022

Copy link
Copy Markdown
MemberAuthor

One more review would be appreciated to unblock upcoming accessibility improvements #27869 :)

@Pytal
Consolidate account property getters
3430808
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytalforce-pushed the enh/27869/consolidate branch from ae18cdd to 3430808CompareJuly 21, 2022 01:14
@PVince81
PVince81 merged commit 623d533 into masterJul 26, 2022
@PVince81
PVince81 deleted the enh/27869/consolidate branch July 26, 2022 07:13
@skjnldsvskjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81PVince81PVince81 approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@szaimenszaimenAwaiting requested review from szaimen
@come-nccome-ncAwaiting requested review from come-nc
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwl
@marcoambrosinimarcoambrosiniAwaiting requested review from marcoambrosini
@raimund-schluesslerraimund-schluesslerAwaiting requested review from raimund-schluessler

Assignees

@PytalPytal

Labels

3. to reviewWaiting for reviewsfeature: accessibilityfeature: settings

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

3 participants

@Pytal@PVince81@CarlSchwan