Uh oh!
There was an error while loading. Please reload this page.
Fix sharing panel lighthouse warnings - #33321
Merged
Merged
Conversation
Replaced h5 with span and adjusted selectors. Fixed ul/li hierarchy of some elements. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
requested review from
CarlSchwan, JuliaKirschenheuter, Pytal, artonge and nickvergessenJuly 22, 2022 15:56
PVince81
commented
Jul 22, 2022
MemberAuthor
I tried using the exact same versions of node and npm like CI and there's no difference. |
MemberAuthor
(and yes I can summon the bot but now I'm really tired that every PR doesn't match expectations) |
PVince81
commented
Jul 22, 2022
MemberAuthor
even with a fresh clone I get the same result as the previous commit... |
PVince81
commented
Jul 22, 2022
MemberAuthor
ah, so it's the icons: dist/icons.css I thought we added a step to build it as part of "make build-js-production" |
PVince81
commented
Jul 22, 2022
MemberAuthor
alright... need to finish #32753 |
PVince81
commented
Jul 22, 2022
MemberAuthor
/compile amend / |
node v14.20.0 npm 8.15.0 Signed-off-by: Vincent Petry <vincent@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
bugfix/noid/fix-sharing-lighthouse-issues
branch
from
July 22, 2022 17:17
9ac7a95 to
b7ae739ComparePytal
approved these changes
Jul 22, 2022
artonge
approved these changes
Jul 25, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced h5 with span and adjusted selectors.
Fixed ul/li hierarchy of some elements.
Found by running the Lighthouse chromium tool in snapshot mode while having the share panel open AND the link share dropdown