Skip to content

Fix typos in lib/public subdirectory - #33381

Merged
skjnldsv merged 1 commit into
nextcloud:masterfrom
luzpaz:fix/lib-public-typos
May 11, 2023
Merged

Fix typos in lib/public subdirectory#33381
skjnldsv merged 1 commit into
nextcloud:masterfrom
luzpaz:fix/lib-public-typos

Conversation

@luzpaz

Copy link
Copy Markdown
Contributor

Found via codespell -q 3 -S l10n -L jus ./lib/private

Signed-off-by: luz paz luzpaz@github.com

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks fine

@PVince81PVince81 added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Jul 27, 2022
@PVince81PVince81 added this to the Nextcloud 25 milestone Jul 27, 2022
Comment threadlib/public/Accounts/IAccount.php Outdated
@luzpaz
luzpazforce-pushed the fix/lib-public-typos branch from f488ef6 to 4993285CompareJuly 28, 2022 10:21
@luzpaz

Copy link
Copy Markdown
ContributorAuthor

Squashed. Shall I also rebase or not necessary?

@come-nc

Copy link
Copy Markdown
Contributor

Squashed. Shall I also rebase or not necessary?

I do not think a rebase is needed, but the DCO bot is somehow unhappy, can you look into it?

@luzpaz
luzpazforce-pushed the fix/lib-public-typos branch from 4993285 to 3543afaCompareJuly 28, 2022 12:18
@luzpaz

Copy link
Copy Markdown
ContributorAuthor

Not sure why.

@szaimen

szaimen commented Jul 28, 2022

Copy link
Copy Markdown
Contributor

I think it expects a different mail but this is not a problem and we can just set it to pass, afaics.

Edit: done

This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@blizzzblizzz mentioned this pull request Feb 1, 2023
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
@blizzzblizzz mentioned this pull request Mar 7, 2023
@blizzzblizzz removed this from the Nextcloud 26 milestone Mar 9, 2023
@blizzzblizzz added this to the Nextcloud 27 milestone Mar 9, 2023
@szaimen
szaimenforce-pushed the fix/lib-public-typos branch from 3543afa to d10264fCompareApril 17, 2023 13:53
@szaimen
szaimen enabled auto-merge April 17, 2023 13:53
This was referenced May 3, 2023
@skjnldsv

Copy link
Copy Markdown
Member

Please fix conflict and we can merge

@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 10, 2023
@skjnldsv
skjnldsv disabled auto-merge May 10, 2023 09:50
Found via `codespell -q 3 -S l10n -L jus ./lib/public`
Signed-off-by: luz paz <luzpaz@github.com>
Update lib/public/Accounts/IAccount.php
Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: Simon L <szaimen@e.mail.de>
Co-Authored-By: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
@szaimen
szaimenforce-pushed the fix/lib-public-typos branch from d10264f to d55a7c6CompareMay 10, 2023 09:57
@szaimen
szaimen enabled auto-merge May 10, 2023 09:59
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels May 11, 2023
@skjnldsv
skjnldsv disabled auto-merge May 11, 2023 08:26
@skjnldsv
skjnldsv merged commit 979f403 into nextcloud:masterMay 11, 2023
@luzpaz
luzpaz deleted the fix/lib-public-typos branch May 13, 2023 20:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishtechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@luzpaz@come-nc@szaimen@skjnldsv@PVince81@blizzz