Skip to content

Fix typos in apps/ subdirectory - #33393

Closed
luzpaz wants to merge 1 commit into
nextcloud:masterfrom
luzpaz:fix/apps-typos
Closed

Fix typos in apps/ subdirectory#33393
luzpaz wants to merge 1 commit into
nextcloud:masterfrom
luzpaz:fix/apps-typos

Conversation

@luzpaz

Copy link
Copy Markdown
Contributor

Found via codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/

Signed-off-by: luz paz luzpaz@github.com

@luzpaz
luzpaz requested a review from CarlSchwan as a code ownerJuly 28, 2022 11:12
@CarlSchwan
CarlSchwan requested review from a team, blizzz and come-nc and removed request for a teamAugust 2, 2022 20:05
@CarlSchwanCarlSchwan added the 3. to review Waiting for reviews label Aug 2, 2022
@CarlSchwanCarlSchwan added this to the Nextcloud 25 milestone Aug 2, 2022
@come-nc

Copy link
Copy Markdown
Contributor

@luzpaz Can you rebase please?

Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`
Signed-off-by: luz paz <luzpaz@github.com>
@luzpaz

Copy link
Copy Markdown
ContributorAuthor

@come-nc, indeed, rebased.

@come-nc

Copy link
Copy Markdown
Contributor

@CarlSchwan It needs a compile-amend I think, but I suppose the bot cannot do that on an external repo? Do you know the manual command required to fix it?

This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
@come-nc

Copy link
Copy Markdown
Contributor

@luzpaz Can you run npm ci && npm run build and commit the result ?

If not I can import your branch in a local branch and do it.

@luzpaz

Copy link
Copy Markdown
ContributorAuthor

I'd rather not run npm 🤣

@come-nc

Copy link
Copy Markdown
Contributor

I'd rather not run npm rofl

I’ll take it from here then.

@come-nc

come-nc commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

Superseeded by #33895

@come-nccome-nc closed this Sep 5, 2022
@come-nc

Copy link
Copy Markdown
Contributor

@luzpaz Merged, thanks a lot.

@luzpaz
luzpaz deleted the fix/apps-typos branch September 6, 2022 13:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@luzpaz@come-nc@CarlSchwan