Skip to content

#33036 [Bug]: Set default expiration date - #33396

Merged
PVince81 merged 1 commit into
nextcloud:masterfrom
Xavierando:#33036-Set-default-expiration-date-(shareapiDefaultExpireDate)
Sep 1, 2022
Merged

#33036 [Bug]: Set default expiration date#33396
PVince81 merged 1 commit into
nextcloud:masterfrom
Xavierando:#33036-Set-default-expiration-date-(shareapiDefaultExpireDate)

Conversation

@Xavierando

Copy link
Copy Markdown
Contributor

two input with same id and content
probably a never done clean up after a duplication of the line of code for beautify

#33036

@szaimenszaimen added bug 3. to review Waiting for reviews labels Jul 28, 2022
@szaimenszaimen added this to the Nextcloud 25 milestone Jul 28, 2022
@szaimen
szaimen requested review from a team, CarlSchwan, PVince81, skjnldsv and szaimen and removed request for a teamJuly 28, 2022 20:50
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
PVince81 merged commit af29b97 into nextcloud:masterSep 1, 2022
@welcome

welcomeBot commented Sep 1, 2022

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@PVince81

Copy link
Copy Markdown
Member

@Xavierando nice catch! thanks a lot

@come-nc

Copy link
Copy Markdown
Contributor

This is from here: #31194 (review)

Thank you for testing and fixing this!

@szaimen

Copy link
Copy Markdown
Contributor

Backport to 24?

@szaimen

Copy link
Copy Markdown
Contributor

/backport to stable24

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Xavierando@PVince81@come-nc@szaimen@Pytal@skjnldsv