Skip to content

Add birthday calendar configuration to groupware personal settings UI - #33397

Closed
cneukom wants to merge 10 commits into
nextcloud:masterfrom
cneukom:feature/birthday-calendar-reminder-settings
Closed

Add birthday calendar configuration to groupware personal settings UI#33397
cneukom wants to merge 10 commits into
nextcloud:masterfrom
cneukom:feature/birthday-calendar-reminder-settings

Conversation

@cneukom

@cneukomcneukom commented Jul 28, 2022

Copy link
Copy Markdown

Closes#1505.

Cédric Neukom
Add birthday calendar configuration to personal settings UI
19b08b3
Signed-off-by: Cédric Neukom <github@webguy.ch>
@szaimenszaimen added enhancement 3. to review Waiting for reviews labels Jul 28, 2022
@szaimenszaimen added this to the Nextcloud 25 milestone Jul 28, 2022
@szaimen
szaimen requested review from a team, ChristophWurst, PVince81, Pytal, artonge and st3iny and removed request for a teamJuly 28, 2022 19:59
Cédric Neukom added 3 commits July 28, 2022 22:11
Cédric Neukom
Fix eslint
4a0c35d
Signed-off-by: Cédric Neukom <github@webguy.ch>
Cédric Neukom
Fix eslint, attempt#2
0e4dae1
Signed-off-by: Cédric Neukom <github@webguy.ch>
Cédric Neukom
Fix import path
a87e93f
Signed-off-by: Cédric Neukom <github@webguy.ch>
@cneukomcneukom mentioned this pull request Jul 28, 2022
Closed
kesselb
kesselb reviewed Jul 28, 2022
View reviewed changes
Comment threadapps/dav/lib/Settings/BirthdayCalendarSettings.php Outdated
@cneukomcneukom mentioned this pull request Jul 28, 2022
Open
Cédric Neukom added 3 commits July 28, 2022 23:01
Cédric Neukom
Remove obsolete initialState
66fef08
Signed-off-by: Cédric Neukom <github@webguy.ch>
Cédric Neukom
Provide initial birthdayCalendarReminderOffset as initialState
13364c4
Signed-off-by: Cédric Neukom <github@webguy.ch>
Cédric Neukom
Provide initial birthdayCalendarEnabled as initialState instead of fe…
865967b
…tching it from the DAV server
Signed-off-by: Cédric Neukom <github@webguy.ch>
@tcitworldtcitworld changed the title Add birthday calendar configuration to personal settings UIAdd birthday calendar configuration to groupware personal settings UIAug 1, 2022
@skjnldsvskjnldsv mentioned this pull request Aug 12, 2022
Merged
tcitworld
tcitworld reviewed Aug 15, 2022
View reviewed changes
Comment threadapps/dav/l10n/en_GB.js Outdated
Comment threadapps/dav/lib/Settings/BirthdayCalendarSettings.php
Cédric Neukom
Separate initial state for BirthdayCalendarSettings and remove manual…
ebc7958
…ly added translations.
Signed-off-by: Cédric Neukom <github@webguy.ch>
@skjnldsvskjnldsv mentioned this pull request Aug 18, 2022
Merged
@blizzzblizzz mentioned this pull request Aug 24, 2022
Merged
@blizzzblizzz added this to the Nextcloud 27 milestone Mar 9, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
@blizzzblizzz mentioned this pull request May 17, 2023
Merged
@blizzzblizzz modified the milestones: Nextcloud 27, Nextcloud 28May 23, 2023
@tcitworld
tcitworld self-requested a review August 19, 2023 09:09
@joshtrichardsjoshtrichards mentioned this pull request Sep 30, 2023
Open
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@Epse

Epse commented Jan 25, 2024

Copy link
Copy Markdown

This feels like necro-ing, but what are the realistic odds of this PR landing anytime soon? It has been open for a painful while now. I was looking into the issue solved by this earlier, but it seems code contributions are not needed at this time.

@tcitworld

This comment was marked as resolved.

Sign in to view
@joshtrichardsjoshtrichards added the feature: caldav Related to CalDAV internals label Mar 5, 2024
@AltahrimAltahrim mentioned this pull request Mar 12, 2024
Merged
This was referenced Mar 14, 2024
Merged
Merged
Merged
@AltahrimAltahrim mentioned this pull request Mar 25, 2024
Merged
@skjnldsvskjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@cneukomcneukom closed this by deleting the head repository Mar 28, 2024
@skjnldsvskjnldsv removed this from the Nextcloud 29 milestone Aug 14, 2024
@stietzstietz mentioned this pull request Feb 28, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbAwaiting requested review from kesselb
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@tcitworldtcitworldAwaiting requested review from tcitworld

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsenhancementfeature: caldavRelated to CalDAV internals

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Users should be able to choose whether reminders are generated for events in the birthday calendar

10 participants

@cneukom@tcitworld@jancborchardt@Epse@kesselb@joshtrichards@blizzz@skjnldsv@szaimen@Altahrim