Skip to content

Remake profile picture saving with Vue - #33409

Merged
Pytal merged 1 commit into
masterfrom
enh/27869/avatar
Sep 2, 2022
Merged

Remake profile picture saving with Vue#33409
Pytal merged 1 commit into
masterfrom
enh/27869/avatar

Conversation

@Pytal

@PytalPytal commented Jul 30, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Remake profile picture saving with Vue for accessibility purposes

Legacy code is removed

  • OC.Settings.updateAvatar is dropped and is an API break but low impact as it is unused
  • Drop deprecated @nextcloud/jcrop dependency

Screenshots

BeforeAfter
imageimage
imageimage

@PytalPytal added this to the Nextcloud 25 milestone Jul 30, 2022
@PytalPytal self-assigned this Jul 30, 2022
@PytalPytal mentioned this pull request Jul 30, 2022
Closed
11 tasks
@Pytal
Pytalforce-pushed the enh/27869/avatar branch 3 times, most recently from 46bde58 to 5d650ecCompareAugust 5, 2022 03:28
github-advanced-security[bot]
github-advanced-securityAI found potential problems Aug 5, 2022
View reviewed changes
Comment threadcore/Controller/AvatarController.php Fixed
@Pytal
Pytalforce-pushed the enh/27869/avatar branch 2 times, most recently from cedfb32 to 8449ce9CompareAugust 6, 2022 06:30
@Pytal
Pytalforce-pushed the enh/27869/twitter branch from 7fd6634 to df757f3CompareAugust 9, 2022 03:09
@Pytal
Pytalforce-pushed the enh/27869/avatar branch 3 times, most recently from 8769877 to 623d961CompareAugust 9, 2022 05:13
@PytalPytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 9, 2022
@Pytal
Pytalforce-pushed the enh/27869/avatar branch 4 times, most recently from d9484f7 to c230dc6CompareAugust 10, 2022 04:52
This was referenced Aug 12, 2022
Merged
Merged
@blizzzblizzz mentioned this pull request Aug 24, 2022
Merged
@Pytal
Pytal requested a review from CarlSchwan as a code ownerAugust 27, 2022 00:30
@Pytal
Pytal requested review from a team, PVince81, artonge and skjnldsv and removed request for a teamAugust 27, 2022 00:31
@skjnldsv

skjnldsv commented Aug 27, 2022

Copy link
Copy Markdown
Member

The cropper part was put inline in the page to be inline edited like other fields but we can put it back in a modal like before if desired @jancborchardt@nimishavijay?

Not sure we gain that much to be in a modal? Maybe just a little more focus? I think it's fine both ways, so if it's technically easier inline, so be it.
But since this is design let's still wait for the design team confirmation :)

@blizzzblizzz mentioned this pull request Aug 30, 2022
Merged
@Pytal

Pytal commented Sep 1, 2022

Copy link
Copy Markdown
MemberAuthor

Rebased

Not sure we gain that much to be in a modal? Maybe just a little more focus? I think it's fine both ways, so if it's technically easier inline, so be it.

Not necessarily technically easier just that editing stuff inline in the same place that it's displayed seems more intuitive, other than that don't have a strong leaning either way

@skjnldsv

skjnldsv commented Sep 1, 2022

Copy link
Copy Markdown
Member

Integration is failing
https://drone.nextcloud.com/nextcloud/server/22585/22/3

@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 1, 2022
@Pytal
Pytalforce-pushed the enh/27869/avatar branch 2 times, most recently from 206d366 to c54504cCompareSeptember 1, 2022 17:21
@Pytal

Pytal commented Sep 1, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Rebased with fixed integration tests

@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 1, 2022
@Pytal
Remake profile picture saving with Vue
f44d258
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytal merged commit 8d2532c into masterSep 2, 2022
@Pytal
Pytal deleted the enh/27869/avatar branch September 2, 2022 04:01
@Pytal

Pytal commented Sep 2, 2022

Copy link
Copy Markdown
MemberAuthor

If there are any further changes we should make @jancborchardt@nimishavijay just ping here

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@PVince81PVince81Awaiting requested review from PVince81
@artongeartongeAwaiting requested review from artonge
@nimishavijaynimishavijayAwaiting requested review from nimishavijay
@jancborchardtjancborchardtAwaiting requested review from jancborchardt

Assignees

@PytalPytal

Labels

4. to releaseReady to be released and/or waiting for tests to finishaccessibilityenhancementfeature: accessibilityfeature: settings

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

4 participants

@Pytal@skjnldsv@CarlSchwan@github-advanced-security