Skip to content

allow disabling object store write check - #33458

Merged
skjnldsv merged 2 commits into
masterfrom
object-store-validate-write
Oct 26, 2022
Merged

allow disabling object store write check#33458
skjnldsv merged 2 commits into
masterfrom
object-store-validate-write

Conversation

@icewind1991

Copy link
Copy Markdown
Member

In clustered setups replication delay means that trying to read the object directly after writing it can fail.

This allows disabling the check by setting 'validateWrites' => false under the object store arguments in config.php

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Aug 4, 2022
@icewind1991icewind1991 added this to the Nextcloud 25 milestone Aug 4, 2022
@icewind1991
icewind1991 requested review from a team, CarlSchwan, juliusknorr and skjnldsv and removed request for a teamAugust 4, 2022 11:12

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81

Copy link
Copy Markdown
Member

so disabling it by default might cause problems in some scenarios ?

This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
@PVince81

Copy link
Copy Markdown
Member

/rebase

@PVince81PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 16, 2022
This was referenced Sep 20, 2022
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@blizzz

Copy link
Copy Markdown
Member

/rebase

@nextcloud-command
nextcloud-commandforce-pushed the object-store-validate-write branch from 501cb17 to a179128CompareOctober 1, 2022 19:59
@skjnldsv

Copy link
Copy Markdown
Member

/rebase

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991@PVince81@blizzz@skjnldsv@juliusknorr