Skip to content

make it possible to run occ as root - #33545

Merged
susnux merged 1 commit into
masterfrom
occ-as-root
Feb 27, 2025
Merged

make it possible to run occ as root#33545
susnux merged 1 commit into
masterfrom
occ-as-root

Conversation

@karlitschek

@karlitschekkarlitschek commented Aug 15, 2022•
edited by ChristophWurst
Loading

Copy link
Copy Markdown
Member

make it possible to run as root

To do

  • Start non privileged child process
  • Handle exit codes
  • Handle STDIN/STDOUT/STDERR streams

@karlitschek

karlitschek commented Aug 15, 2022

Copy link
Copy Markdown
MemberAuthor

@CarlSchwan@PVince81@nickvergessen@AndyScherzinger

@PVince81PVince81 added the 3. to review Waiting for reviews label Aug 15, 2022
@PVince81PVince81 added this to the Nextcloud 25 milestone Aug 15, 2022
nickvergessen
nickvergessen reviewed Aug 15, 2022
View reviewed changes
Comment threadocc Outdated
nickvergessen
nickvergessen requested changes Aug 15, 2022
View reviewed changes
Comment threadocc Outdated
tcitworld
tcitworld reviewed Aug 16, 2022
View reviewed changes
Comment threadocc Outdated
@skjnldsvskjnldsv mentioned this pull request Aug 18, 2022
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@blizzzblizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzzblizzz mentioned this pull request Mar 7, 2023
Merged
@blizzzblizzz modified the milestones: Nextcloud 26, Nextcloud 27Mar 9, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
@skjnldsvskjnldsv removed this from the Nextcloud 27 milestone May 9, 2023
@blizzzblizzz added this to the Nextcloud 29 milestone Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
Merged
@ChristophWurst

ChristophWurst commented Sep 18, 2024

Copy link
Copy Markdown
Member

Finding the right user is doable from config.php ownership guessing.

The tricky part is STDIN/STDOUT/STDERR handling. Neither with shell_exec nor proc_open I was able to connect the parent process pipes with the child process. shell_exec makes the parent block when occ asks for input (e.g. when you make a typo or when it needs confirmation).

I've pushed some fixes that make this work on a non-Debian system too.

@skjnldsvskjnldsv added this to the Nextcloud 32 milestone Jan 30, 2025
@susnux

susnux commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

@ChristophWurst I pushed a commit which should resolve this.
Basically lets do it like every other program on Linux and just use setuid and setgid to make the current process owned by the config.php user.

Also there is no need for a fallback, because if there is no fileowner of the config, then console.php will fail because it checks that the current user is the fileowner...

@susnuxsusnux added 3. to review Waiting for reviews and removed 2. developing Work in progress stale Ticket or PR with no recent activity labels Feb 27, 2025
ChristophWurst
ChristophWurst approved these changes Feb 27, 2025
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Very nice solution, @susnux 👏

nickvergessen
nickvergessen approved these changes Feb 27, 2025
View reviewed changes

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files belong to my own user. Works fine here with:

  • php occ
  • sudo php occ
  • sudo -u nickvergessen php occ

So sounds good to me

@nickvergessen

nickvergessen commented Feb 27, 2025

Copy link
Copy Markdown
Member

I will then squash it and we can merge + backport it, looks straight forward enough :-O

@karlitschek@nickvergessen
fix(occ): Make it possible to run as root
53c083e
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux merged commit 8f28fa2 into masterFeb 27, 2025
@susnux
susnux deleted the occ-as-root branch February 27, 2025 21:21
@nickvergessen

nickvergessen commented Feb 27, 2025

Copy link
Copy Markdown
Member

/backport to stable31

@nickvergessen

nickvergessen commented Feb 27, 2025

Copy link
Copy Markdown
Member

/backport to stable30

This was referenced Feb 27, 2025
Merged
Merged
@karlitschek

karlitschek commented Feb 27, 2025

Copy link
Copy Markdown
MemberAuthor

Wohoooo. Feeling like a community contributor now 😀

@karlitschek

karlitschek commented Feb 27, 2025

Copy link
Copy Markdown
MemberAuthor

Ok. Nothing of my code is left. Bit still cool 😎

@provokateurinprovokateurin mentioned this pull request Mar 20, 2025
Merged
4 tasks
@nextcloud-botnextcloud-bot mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81PVince81PVince81 left review comments
@tcitworldtcitworldtcitworld left review comments
@nickvergessennickvergessennickvergessen approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsfeature: occ

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

9 participants

@karlitschek@AndyScherzinger@skjnldsv@ChristophWurst@susnux@nickvergessen@PVince81@tcitworld@blizzz