Uh oh!
There was an error while loading. Please reload this page.
use lazy user in UserMountCache - #33579
Closed
icewind1991 wants to merge 1 commit into
Closed
Conversation
icewind1991
requested review from
a team, blizzz, juliusknorr and skjnldsv
and removed request for
a teamAugust 17, 2022 12:19
CarlSchwan
approved these changes
Aug 17, 2022
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
mountcache-lazy-user
branch
from
August 17, 2022 12:35
98d06cd to
5fc5cf1Compare| $userid = $row['user_id']; | ||
| // check that the user exits | ||
| if ($this->userManager->getDisplayName($userid) === null) { |
Member
There was a problem hiding this comment.
Not fond of this check, seems hack-ish, no?
MemberAuthor
There was a problem hiding this comment.
A bit yes, but it's the easiest way I can think of to do this check without requesting data from the user backend if not needed
MemberAuthor
There was a problem hiding this comment.
#33582 add caching to userExists, will adjust this PR once that is merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robin Appelman robin@icewind.nl