Skip to content

use LazyUser in DefaultShareProvider - #33581

Merged
blizzz merged 2 commits into
masterfrom
share-lazy-user
Jun 17, 2024
Merged

use LazyUser in DefaultShareProvider#33581
blizzz merged 2 commits into
masterfrom
share-lazy-user

Conversation

@icewind1991

@icewind1991icewind1991 commented Aug 17, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Aug 17, 2022
@icewind1991icewind1991 added this to the Nextcloud 25 milestone Aug 17, 2022
@icewind1991
icewind1991 requested review from a team, ArtificialOwl, PVince81 and come-nc and removed request for a teamAugust 17, 2022 12:30
PVince81
PVince81 approved these changes Aug 17, 2022
View reviewed changes

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

artonge
artonge reviewed Aug 17, 2022
View reviewed changes
Comment threadlib/private/Share20/DefaultShareProvider.php
@skjnldsvskjnldsv mentioned this pull request Aug 18, 2022
Merged
@nickvergessen

nickvergessen commented Aug 18, 2022

Copy link
Copy Markdown
Member

Tests: 4297, Assertions: 15882, Failures: 11, Skipped: 28, Risky: 1.

DB unit tests are failing

@PVince81

PVince81 commented Aug 23, 2022

Copy link
Copy Markdown
Member

@icewind1991 please fix the tests

This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Merged
@PVince81PVince81 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 16, 2022
This was referenced Sep 20, 2022
Closed
Merged
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@blizzzblizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzzblizzz added this to the Nextcloud 27 milestone Mar 9, 2023
@szaimen

szaimen commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

@icewind1991 can you please fix the tests?

This was referenced May 3, 2023
Merged
Closed
Merged
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@icewind1991@come-nc
use LazyUser in DefaultShareProvider
7f6a891
Signed-off-by: Robin Appelman <robin@icewind.nl>
@come-nc

come-nc commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

Rebased and fixed conflicts

@come-nc
fix(tests): Fix tests with new LazyUser usage in DefaultShareProvider
de6bb33
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@blizzz
blizzz merged commit 2bc949d into masterJun 17, 2024
@blizzz
blizzz deleted the share-lazy-user branch June 17, 2024 20:53
@blizzzblizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge left review comments
@PVince81PVince81PVince81 approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwl
@blizzzblizzzAwaiting requested review from blizzz

Assignees

No one assigned

Labels

2. developingWork in progressperformance 🚀

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

9 participants

@icewind1991@nickvergessen@PVince81@szaimen@come-nc@artonge@CarlSchwan@blizzz@skjnldsv