Uh oh!
There was an error while loading. Please reload this page.
Move findBinaryFinder and isFunctionEnabled away from OC_Helper - #33593
Merged
Conversation
CarlSchwan
requested review from
ArtificialOwl, blizzz and come-nc
and removed request for
a teamAugust 18, 2022 08:58
CarlSchwanforce-pushed
the
improve-binary-caching
branch
from
August 18, 2022 08:59
b2e9370 to
8b99dbfCompareCarlSchwanforce-pushed
the
improve-binary-caching
branch
2 times, most recently
from
August 18, 2022 10:04
9351f1d to
7669331Compareblizzz
approved these changes
Aug 18, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
come-nc
requested changes
Aug 22, 2022
Uh oh!
There was an error while loading. Please reload this page.
CarlSchwanforce-pushed
the
improve-binary-caching
branch
from
August 23, 2022 09:37
a25a7cc to
27d6950CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
CarlSchwanforce-pushed
the
improve-binary-caching
branch
from
August 23, 2022 11:05
27d6950 to
d253787CompareChristophWurst
approved these changes
Aug 23, 2022
come-nc
reviewed
Aug 23, 2022
Uh oh!
There was an error while loading. Please reload this page.
come-nc
reviewed
Aug 23, 2022
Uh oh!
There was an error while loading. Please reload this page.
CarlSchwanforce-pushed
the
improve-binary-caching
branch
from
August 23, 2022 12:29
d253787 to
338ea06Comparecome-nc
approved these changes
Aug 23, 2022
CarlSchwanforce-pushed
the
improve-binary-caching
branch
from
August 23, 2022 13:22
338ea06 to
746a529ComparefindBinaryFinder is now a service that is still private but with some minor optimization (remove the hasKey check). isFunctionEnabled is now in OCP\Util Both function are still keep but all internal usage in nextcloud/server were migrated to the new usage, so that we can remove it in 26 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwanforce-pushed
the
improve-binary-caching
branch
from
August 23, 2022 17:44
746a529 to
9b8ca9aComparenickvergessen
approved these changes
Aug 24, 2022
Uh oh!
There was an error while loading. Please reload this page.
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findBinaryFinder is now a service that is still private but with some
minor optimization (remove the hasKey check).
isFunctionEnabled is now in OCP\Util
Both functions are still kept but all internal usage in nextcloud/server
were migrated to the new usage, so we can remove it in 26.
Before: 2 redis cache requests either hasKey and get or hasKey and set
Now: 1 redis cache request (get) or 2 redis cache requests (get and set)