Skip to content

get quota for user only when needed - #33600

Merged
blizzz merged 1 commit into
masterfrom
lazy-quota
Sep 7, 2022
Merged

get quota for user only when needed#33600
blizzz merged 1 commit into
masterfrom
lazy-quota

Conversation

@icewind1991

Copy link
Copy Markdown
Member

always apply the wrapper but have the wrapper get the quota lazily only when an operation where quota is applied is performed

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991icewind1991 added this to the Nextcloud 25 milestone Aug 18, 2022
@icewind1991
icewind1991 requested review from a team, PVince81, blizzz and come-nc and removed request for a teamAugust 18, 2022 09:43
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2022

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blizzz

Copy link
Copy Markdown
Member

CI is unhappy

This was referenced Aug 24, 2022
always apply the wrapper but have the wrapper get the quota lazily only when an operation where quota is applied is performed
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991

Copy link
Copy Markdown
MemberAuthor

tests fixed

Comment threadlib/private/Files/Storage/Wrapper/Quota.php
@blizzzblizzz mentioned this pull request Sep 6, 2022
@blizzz
blizzz merged commit 417f46e into masterSep 7, 2022
@blizzz
blizzz deleted the lazy-quota branch September 7, 2022 16:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsperformance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@blizzz@PVince81