CSS changes for better distinction between user name and full name in user list by Jerome-Herbinet · Pull Request #33669 · nextcloud/server

Jerome-Herbinet · 2022-08-24T08:45:09Z

Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr

Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com

…name Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

szaimen

Lgtm but didn't test

This reverts commit 6879c01.

Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr

Jerome-Herbinet · 2022-08-24T14:21:23Z

What is in the commit branch ? is this normal ? any problem ?
3rdparty
Viewed
Submodule 3rdparty updated 164 files

jancborchardt

Good idea! Some design feedback:

We never use italic cause it is not so easily legible
Instead, we could bold the display name
Display name should show in first row, then account name, so it doesn't look weird with a bold subline
That variable looks non-standard, we only use either color-main-text or color-text-maxcontrast. But if we bold the display name, we don't need to reduce the color of the account name.

szaimen · 2022-08-24T15:15:38Z

What is in the commit branch ? is this normal ? any problem ? 3rdparty Viewed Submodule 3rdparty updated 164 files

This change needs to be reverted. See https://stackoverflow.com/questions/30275691/removing-subproject-commit-from-github/30275888#30275888

Jerome-Herbinet · 2022-08-25T07:20:06Z

@szaimen I think I've removed it ; can you tell me if it's OK ? (submodule)

Jerome-Herbinet · 2022-08-25T07:22:59Z

Good idea! Some design feedback:

* [ ] We never use italic cause it is not so easily legible
* [ ] Instead, we could bold the display name
* [ ] Display name should show in first row, then account name, so it doesn't look weird with a bold subline
* [ ] That variable looks non-standard, we only use either color-main-text or color-text-maxcontrast. But if we bold the display name, we don't need to reduce the color of the account name.

@jancborchardt thanks for your suggestions ; I'll take care of it.

This reverts commit 3e2190e.

This reverts commit 3f0ca0d.

@jancborchardt

@jancborchardt Italic removed. Bold "only" is not enough. Bold AND "color-main-text" is too much (too aggressive). So I propose only using color-main-text. I think I don't have skills to invert lines (and I'm afraid of doing this myself now) ; can someone else do it ? Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr

Jerome-Herbinet · 2022-08-25T08:01:48Z

following

szaimen · 2022-08-25T13:10:51Z

-[submodule "3rdparty"]
-	path = 3rdparty
-	url = https://github.com/nextcloud/3rdparty.git


hm... seems like following my link removed too much :/
@skjnldsv do you know how to fix that?

@StCyr une idée ?

szaimen · 2022-08-25T13:11:27Z

@Jerome-Herbinet thanks! Can you please post a new screenshot? That would be great!

Jerome-Herbinet · 2022-08-25T13:30:46Z

@Jerome-Herbinet thanks! Can you please post a new screenshot? That would be great!

@szaimen here it is :

szaimen · 2022-08-25T13:31:52Z

cc @jancborchardt

jancborchardt · 2022-08-25T15:23:59Z

@Jerome-Herbinet almost :) could you:

Unbold the account name, as the display name is already bold
Put display name in the first line, accoint in the second (not soo important if difficult)

Jerome-Herbinet · 2022-08-25T16:17:50Z

@Jerome-Herbinet almost :) could you:

* Unbold the account name, as the display name is already bold
* Put display name in the first line, accoint in the second (not soo important if difficult)

@jancborchardt in fact the text isn't bold ; the other screenshot boldness is certainly due to the default font of my Ubuntu Laptop.

Here is a screenshot of the same NC instance, under Manjaro.

So do you want me to bold something ?

And about putting the display name in first position, I won't be able to do it my self (sorry).

jancborchardt · 2022-08-25T16:48:40Z

@Jerome-Herbinet ah got it, thanks for the screenshot! Then I'd only say it would be nice to bold the display name (best use a <strong> tag for semantic markup).

Remove "displayName" class call to target "subtitle" class in users list AND in table header. Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr

For PR nextcloud#33669 Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr

Jerome-Herbinet · 2022-08-26T08:11:44Z

@Jerome-Herbinet ah got it, thanks for the screenshot! Then I'd only say it would be nice to bold the display name (best use a \<strong\> tag for semantic markup).

Done @jancborchardt

Display name is bold ... event if on my "day" computer, difference between bold and not bold texte isn't very visible ... (with "strong") and display name and user name are inverted now.

Jerome-Herbinet · 2022-08-26T08:16:36Z

As a newbie as code contributor, I made an error, by committing 5f9962d ... I think I've cancelled it, can you confirm ? (sorry for the mess, I'm learning).

Jerome-Herbinet · 2022-08-26T08:17:45Z

I'm concerned about submodule problem ; do you have a tip to solve it ?

Jerome-Herbinet · 2022-09-20T13:26:10Z

Hello,
If the Submodule problem is not solvable, do you advise me to close this PR and to create a new one (hopping that it will work better) ?

szaimen · 2022-09-20T13:28:08Z

If the Submodule problem is not solvable, do you advise me to close this PR and to create a new one (hopping that it will work better) ?

Yesy that is probably a good idea. Thanks!

Jerome-Herbinet · 2022-09-20T13:34:27Z

If the Submodule problem is not solvable, do you advise me to close this PR and to create a new one (hopping that it will work better) ?
Yesy that is probably a good idea. Thanks!

OK @szaimen, I close it and tell you when the new PR is created (I'll cross the fingers).

Jerome-Herbinet · 2022-09-20T14:16:01Z

New PR --> #34163

CSS changes for better visual distinction between user name and full …
8316f49
…name Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Jerome-Herbinet changed the title ~~CSS changes for better distinction between user name and full name~~CSS changes for better distinction between user name and full name in user listAug 24, 2022

szaimen added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews labels Aug 24, 2022

szaimen added this to the Nextcloud 25 milestone Aug 24, 2022

szaimen requested review from a team, PVince81, artonge, juliusknorr and skjnldsv and removed request for a teamAugust 24, 2022 10:01

szaimen approved these changes Aug 24, 2022
View reviewed changes

szaimen reviewed Aug 24, 2022
View reviewed changes

Comment threadapps/settings/css/settings.scss Outdated

szaimen requested review from jancborchardt and nimishavijay August 24, 2022 10:03

skjnldsv approved these changes Aug 24, 2022
View reviewed changes

Fix : Tabs deletion
6879c01

szaimen reviewed Aug 24, 2022
View reviewed changes

Comment threadapps/settings/css/settings.scss Outdated

szaimen reviewed Aug 24, 2022
View reviewed changes

Comment threadapps/settings/css/settings.scss Outdated

Jerome-Herbinet added 2 commits August 24, 2022 16:13

Revert "Fix : Tabs deletion"
f75f575
This reverts commit 6879c01.

Fix : Deleting some tabs (code cleaning)
109f0b8
Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr

jancborchardt requested changes Aug 24, 2022
View reviewed changes

blizzz mentioned this pull request Aug 24, 2022
25.0.0 beta 3 #33674
Merged

Removing submodule
3e2190e

Revert "Removing submodule"
3f0ca0d
This reverts commit 3e2190e.

Jerome-Herbinet added 2 commits August 25, 2022 09:31

Revert "Revert "Removing submodule""
f30d4ae
This reverts commit 3f0ca0d.

szaimen reviewed Aug 25, 2022
View reviewed changes

Wider css class call
bc66d1f
Remove "displayName" class call to target "subtitle" class in users list AND in table header. Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr

Jerome-Herbinet added 2 commits August 26, 2022 09:55

Invert user and display name (+ bold display name)
df5937f
Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr

Header : Invert display (+ bold) and user name
0aa0d89
Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr

This was referenced Aug 30, 2022
25.0.0 beta 4 #33762
Merged
25.0.0 beta 5 #33913
Merged

blizzz mentioned this pull request Sep 9, 2022
25.0.0 beta 6 #34002
Merged

skjnldsv mentioned this pull request Sep 15, 2022
25.0.0 beta 7 #34095
Merged

Jerome-Herbinet closed this Sep 20, 2022

Jerome-Herbinet mentioned this pull request Sep 20, 2022
User list : User name and Display name visibility improvement #34163
Merged

szaimen removed this from the Nextcloud 25 milestone Sep 20, 2022

Jerome-Herbinet deleted the patch-3 branch August 31, 2023 09:50

Uh oh!

Uh oh!

Conversation

Jerome-Herbinet commented Aug 24, 2022

Uh oh!

szaimen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jerome-Herbinet commented Aug 24, 2022

Uh oh!

jancborchardt left a comment

Choose a reason for hiding this comment

Uh oh!

szaimen commented Aug 24, 2022

Uh oh!

Jerome-Herbinet commented Aug 25, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jerome-Herbinet commented Aug 25, 2022

Uh oh!

Jerome-Herbinet commented Aug 25, 2022

Uh oh!

szaimenAug 25, 2022

Choose a reason for hiding this comment

Uh oh!

skjnldsvAug 25, 2022

Choose a reason for hiding this comment

Uh oh!

Jerome-HerbinetAug 25, 2022

Choose a reason for hiding this comment

Uh oh!

szaimen commented Aug 25, 2022

Uh oh!

Jerome-Herbinet commented Aug 25, 2022

Uh oh!

szaimen commented Aug 25, 2022

Uh oh!

jancborchardt commented Aug 25, 2022

Uh oh!

Jerome-Herbinet commented Aug 25, 2022

Uh oh!

jancborchardt commented Aug 25, 2022

Uh oh!

Jerome-Herbinet commented Aug 26, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jerome-Herbinet commented Aug 26, 2022

Uh oh!

Jerome-Herbinet commented Aug 26, 2022

Uh oh!

Jerome-Herbinet commented Sep 20, 2022

Uh oh!

szaimen commented Sep 20, 2022

Uh oh!

Jerome-Herbinet commented Sep 20, 2022

Uh oh!

Jerome-Herbinet commented Sep 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Jerome-Herbinet commented Aug 25, 2022•
edited
Loading

Jerome-Herbinet commented Aug 26, 2022•
edited
Loading