Uh oh!
There was an error while loading. Please reload this page.
Make it possible to load theme/<themename>/dist - #33694
Merged
Merged
Conversation
CarlSchwan
commented
Aug 25, 2022
Uh oh!
There was an error while loading. Please reload this page.
skjnldsv
approved these changes
Aug 25, 2022
CarlSchwan
marked this pull request as draft
August 25, 2022 14:37
CarlSchwanforce-pushed
the
fix/load-themedir-dist
branch
from
August 26, 2022 11:44
05375b6 to
dc1fa56CompareCarlSchwanforce-pushed
the
fix/load-themedir-dist
branch
from
August 26, 2022 11:46
dc1fa56 to
a4e865cCompareThis fix a regression with the theming api following the change in webpack bundling introduced in 24 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwanforce-pushed
the
fix/load-themedir-dist
branch
from
August 26, 2022 11:46
a4e865c to
de168b3CompareCarlSchwan
marked this pull request as ready for review
August 26, 2022 12:00
CarlSchwan
commented
Aug 26, 2022
MemberAuthor
Tested and this is working fine |
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
commented
Aug 29, 2022
MemberAuthor
/backport to stable24 |
The backport to stable24 failed. Please do this backport manually. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix a regression with the theming api following the change in
webpack bundling introduced in 24
Signed-off-by: Carl Schwan carl@carlschwan.eu