Skip to content

Use display name cache on getStorageInfo - #33709

Merged
PVince81 merged 1 commit into
masterfrom
enh/displayname-cache-getStorageInfo
Dec 19, 2022
Merged

Use display name cache on getStorageInfo#33709
PVince81 merged 1 commit into
masterfrom
enh/displayname-cache-getStorageInfo

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Aug 26, 2022•
edited
Loading

Copy link
Copy Markdown
Member

While the method result is cached, it still might save a query from time to time and is less code than before

@juliusknorr
juliusknorr requested review from a team, PVince81, blizzz and skjnldsv and removed request for a teamAugust 26, 2022 06:36
PVince81
PVince81 approved these changes Aug 26, 2022
View reviewed changes

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81PVince81 added this to the Nextcloud 25 milestone Aug 26, 2022
@juliusknorr

juliusknorr commented Aug 26, 2022

Copy link
Copy Markdown
MemberAuthor

Will have a look at the failing tests

@juliusknorr
juliusknorrforce-pushed the enh/displayname-cache-getStorageInfo branch from 2a10aea to 1d26f2aCompareAugust 29, 2022 06:17
@juliusknorr

juliusknorr commented Aug 29, 2022

Copy link
Copy Markdown
MemberAuthor

One more remaining:


[Mon Aug 29 06:43:51 2022] {"Exception":"Exception","Message":"Argument 1 passed to OC\\User\\Manager::getDisplayName() must be of the type string, null given, called in \/drone\/src\/lib\/private\/legacy\/OC_Helper.php on line 545 in file '\/drone\/src\/lib\/private\/User\/Manager.php' line 191","Code":0,"Trace":[{"file":"\/drone\/src\/lib\/private\/AppFramework\/App.php","line":172,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/drone\/src\/lib\/private\/Route\/Router.php","line":298,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"\/drone\/src\/lib\/base.php","line":1042,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"\/drone\/src\/index.php","line":36,"function":"handleRequest","class":"OC","type":"::"}],"File":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","Line":165,"Previous":{"Exception":"TypeError","Message":"Argument 1 passed to OC\\User\\Manager::getDisplayName() must be of the type string, null given, called in \/drone\/src\/lib\/private\/legacy\/OC_Helper.php on line 545","Code":0,"Trace":[{"file":"\/drone\/src\/lib\/private\/legacy\/OC_Helper.php","line":545,"function":"getDisplayName","class":"OC\\User\\Manager","type":"->"},{"file":"\/drone\/src\/apps\/files\/lib\/Controller\/ViewController.php","line":155,"function":"getStorageInfo","class":"OC_Helper","type":"::"},{"file":"\/drone\/src\/apps\/files\/lib\/Controller\/ViewController.php","line":205,"function":"getStorageInfo","class":"OCA\\Files\\Controller\\ViewController","type":"->"},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":225,"function":"index","class":"OCA\\Files\\Controller\\ViewController","type":"->"},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":133,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/drone\/src\/lib\/private\/AppFramework\/App.php","line":172,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/drone\/src\/lib\/private\/Route\/Router.php","line":298,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"\/drone\/src\/lib\/base.php","line":1042,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"\/drone\/src\/index.php","line":36,"function":"handleRequest","class":"OC","type":"::"}],"File":"\/drone\/src\/lib\/private\/User\/Manager.php","Line":191},"CustomMessage":"--"}

This was referenced Aug 30, 2022
Merged
Merged
@blizzzblizzz mentioned this pull request Sep 9, 2022
Merged
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Merged
@PVince81PVince81 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 16, 2022
This was referenced Sep 20, 2022
Closed
Merged
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@juliusknorr
juliusknorrforce-pushed the enh/displayname-cache-getStorageInfo branch from 1451f49 to 2f9c914CompareOctober 14, 2022 09:20
@juliusknorr

juliusknorr commented Oct 14, 2022

Copy link
Copy Markdown
MemberAuthor

/rebase

@juliusknorrjuliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 14, 2022
@nextcloud-command
nextcloud-commandforce-pushed the enh/displayname-cache-getStorageInfo branch from 2f9c914 to 5f004d8CompareOctober 14, 2022 22:18
@PVince81

PVince81 commented Dec 16, 2022

Copy link
Copy Markdown
Member

/rebase

@PVince81PVince81 removed the 3. to review Waiting for reviews label Dec 16, 2022
@PVince81PVince81 added the 4. to release Ready to be released and/or waiting for tests to finish label Dec 16, 2022
@juliusknorr@PVince81
Use display name cache on getStorageInfo
1746344
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Adapt test to also run isolated
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@nextcloud-command
nextcloud-commandforce-pushed the enh/displayname-cache-getStorageInfo branch from 5f004d8 to 1746344CompareDecember 16, 2022 17:15
@PVince81
PVince81 merged commit 1bae41c into masterDec 19, 2022
@PVince81
PVince81 deleted the enh/displayname-cache-getStorageInfo branch December 19, 2022 11:07
@PVince81

PVince81 commented Dec 19, 2022

Copy link
Copy Markdown
Member

/backport to stable25

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Dec 19, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81PVince81PVince81 approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@blizzzblizzzAwaiting requested review from blizzz
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishperformance 🚀

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@PVince81@CarlSchwan@blizzz