Skip to content

Move background settings from dashboard app to Appearance and accessibility settings - #33733

Merged
szaimen merged 1 commit into
masterfrom
change/appearance-accessibility-settings
Sep 14, 2022
Merged

Move background settings from dashboard app to Appearance and accessibility settings#33733
szaimen merged 1 commit into
masterfrom
change/appearance-accessibility-settings

Conversation

@GretaD

@GretaDGretaD commented Aug 29, 2022•
edited by Pytal
Loading

Copy link
Copy Markdown
Contributor

For #33736

Screenshot

image

To Do

@GretaDGretaD added the 2. developing Work in progress label Aug 29, 2022
juliusknorr
juliusknorr reviewed Aug 29, 2022
View reviewed changes
Comment threadapps/theming/src/UserThemes.vue Outdated
juliusknorr
juliusknorr reviewed Aug 29, 2022
View reviewed changes
Comment threadapps/theming/src/UserThemes.vue Outdated
juliusknorr
juliusknorr reviewed Aug 29, 2022
View reviewed changes
Comment threadapps/theming/src/UserThemes.vue Outdated
juliusknorr
juliusknorr reviewed Aug 29, 2022
View reviewed changes
Comment threadapps/theming/src/UserThemes.vue Outdated
juliusknorr
juliusknorr reviewed Aug 29, 2022
View reviewed changes
Comment threadapps/theming/src/helpers/prefixWithBaseUrl.js Outdated
juliusknorr
juliusknorr reviewed Aug 29, 2022
View reviewed changes
Comment threadapps/theming/src/UserThemes.vue Outdated
This was referenced Aug 29, 2022
Closed
Merged
Merged
@jancborchardtjancborchardt mentioned this pull request Sep 1, 2022
Closed
1 task
juliusknorr
juliusknorr reviewed Sep 2, 2022
View reviewed changes
Comment threadapps/dashboard/appinfo/routes.php Outdated
@PytalPytal self-assigned this Sep 6, 2022
@jancborchardtjancborchardt mentioned this pull request Sep 6, 2022
Closed
4 tasks
@PytalPytal changed the title Add settings background to theming instead of dashboardMove background settings from dashboard app to Appearance and accessibility settingsSep 8, 2022
@Pytal
Pytalforce-pushed the change/appearance-accessibility-settings branch from 081b0bb to 6857126CompareSeptember 8, 2022 02:09
github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 8, 2022
View reviewed changes

@github-advanced-securitygithub-advanced-securityAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

@Pytal

Pytal commented Sep 8, 2022

Copy link
Copy Markdown
Member

Taking over and rebased for latest redesign changes

@GretaD
GretaD marked this pull request as ready for review September 8, 2022 09:17
@PVince81PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 14, 2022
@nextcloud-command
nextcloud-commandforce-pushed the change/appearance-accessibility-settings branch from ae277d8 to edd24afCompareSeptember 14, 2022 09:10
@szaimen

szaimen commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

Conflicts...

@szaimenszaimen added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Sep 14, 2022
@PVince81

PVince81 commented Sep 14, 2022

Copy link
Copy Markdown
Member

ok, let me rebase and rebuild...

@PVince81
PVince81force-pushed the change/appearance-accessibility-settings branch from edd24af to c4fdce1CompareSeptember 14, 2022 14:35
@PVince81

PVince81 commented Sep 14, 2022

Copy link
Copy Markdown
Member

@Pytal was this actually finished ? the label still says "2 to develop", please adjust accordingly and merge if applicable once ready

@szaimen

szaimen commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

@Pytal was this actually finished ? the label still says "2 to develop", please adjust accordingly and merge if applicable once ready

I added the label. It was finished

@szaimenszaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 14, 2022
@szaimen

szaimen commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

Failing tests seem related

@szaimenszaimen added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Sep 14, 2022
@szaimenszaimen mentioned this pull request Sep 14, 2022
Merged
5 tasks
@Pytal
Pytalforce-pushed the change/appearance-accessibility-settings branch from c4fdce1 to 2eecbdaCompareSeptember 14, 2022 17:55
@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 14, 2022
@Pytal
Pytalforce-pushed the change/appearance-accessibility-settings branch 2 times, most recently from b48b30c to 87fcbc9CompareSeptember 14, 2022 18:07
@GretaD@Pytal
Move background settings from dashboard app to Appearance and accessi…
02cc42d
…bility settings
Signed-off-by: greta <gretadoci@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytalforce-pushed the change/appearance-accessibility-settings branch from 87fcbc9 to 02cc42dCompareSeptember 14, 2022 20:17
@szaimen
szaimen disabled auto-merge September 14, 2022 22:36
@szaimen

szaimen commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

CI failure unrelated

@szaimen
szaimen merged commit 009d5e9 into masterSep 14, 2022
@szaimen
szaimen deleted the change/appearance-accessibility-settings branch September 14, 2022 22:36
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Merged
@PytalPytal mentioned this pull request Oct 7, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81PVince81PVince81 approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@marcoambrosinimarcoambrosiniAwaiting requested review from marcoambrosini
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan

Assignees

@GretaDGretaD

@PytalPytal

Labels

4. to releaseReady to be released and/or waiting for tests to finishaccessibilitydesignDesign, UI, UX, etc.feature: accessibilityfeature: settingsfeature: theming

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

8 participants

@GretaD@Pytal@PVince81@szaimen@ChristophWurst@juliusknorr@CarlSchwan@github-advanced-security