Skip to content

Makes untrusted domain error on info - #33737

Merged
szaimen merged 1 commit into
nextcloud:masterfrom
AndyXheli:patch-4
Oct 1, 2022
Merged

Makes untrusted domain error on info#33737
szaimen merged 1 commit into
nextcloud:masterfrom
AndyXheli:patch-4

Conversation

@AndyXheli

@AndyXheliAndyXheli commented Aug 29, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Signed-off-by: Andy Xheli axheli@axtsolutions.com

Since e6d9ef2 was applied logs get filled up with Trusted domain error. "X.X.X.X tried to access using "X.X.X.X" as host alot of users missed important errors do to e6d9ef2 please see #32599

This should fix.
#32599 (comment)

Andy Xheli
Makes untrusted domain error on info
12c8123
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
Since e6d9ef2 was applied logs get filled up with Trusted domain error. "X.X.X.X tried to access using "X.X.X.X" as host alot of users missed important errors do tohttps://github.com/nextcloud/server/commit/e6d9ef2e38daffcab808eaa41b18ab16c6253b97 please see #32599
This should fix. #32599 (comment)
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
@szaimenszaimen added the 3. to review Waiting for reviews label Aug 29, 2022
@szaimenszaimen added this to the Nextcloud 25 milestone Aug 29, 2022
This was referenced Aug 30, 2022
Merged
Merged
@blizzzblizzz mentioned this pull request Sep 9, 2022
Merged
@BJKle

BJKle commented Sep 12, 2022

Copy link
Copy Markdown

How ist this working?
Is it just luck if the reviewers pick this and check it or is there a formal process available and hasn't been triggered yet?
It is just one word, which is reverted to the value before version 24.
It would be great to have it back with version 25 :-)
Thanks

@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@AndyXheli

AndyXheli commented Sep 28, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Hi All.

Can we please get a review on this?

szaimen
szaimen approved these changes Oct 1, 2022
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

@szaimen
szaimen requested review from a team, come-nc and juliusknorr and removed request for a teamOctober 1, 2022 15:24
come-nc
come-nc approved these changes Oct 1, 2022
View reviewed changes

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear if there is not a better solution here, but for the time being…

@szaimen
szaimen merged commit f97f13b into nextcloud:masterOct 1, 2022
@AndyXheli

AndyXheli commented Oct 1, 2022

Copy link
Copy Markdown
ContributorAuthor

Thank you!! I'm sure there will be some happy admins :)

@AndyXheli
AndyXheli deleted the patch-4 branch October 1, 2022 16:11
@AndyXheli

AndyXheli commented Oct 6, 2022

Copy link
Copy Markdown
ContributorAuthor

Hey @szaimen I just updated to NC 24.0.6 and im not seeing this change in there. and i updated my NC 25 to RC3 and i dont see the change there also Can you please look into this ?

@AndyXheliAndyXheli mentioned this pull request Oct 6, 2022
Closed
8 tasks
@szaimen

szaimen commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

/backport to stable25

@szaimen

szaimen commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

/backport to stable24

This was referenced Oct 6, 2022
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szaimenszaimenszaimen approved these changes
@come-nccome-nccome-nc approved these changes
@pierreozouxpierreozouxAwaiting requested review from pierreozoux
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan
@artongeartongeAwaiting requested review from artonge
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

6 participants

@AndyXheli@BJKle@szaimen@come-nc@blizzz@skjnldsv