Skip to content

Avatar new style - #33752

Merged
CarlSchwan merged 4 commits into
masterfrom
avatar-new-style
Sep 9, 2022
Merged

Avatar new style#33752
CarlSchwan merged 4 commits into
masterfrom
avatar-new-style

Conversation

@CarlSchwan

@CarlSchwanCarlSchwan commented Aug 30, 2022

Copy link
Copy Markdown
Member

Dark theme: image

White theme:
image
image

Also fix a bug where the avatars where not generated with imagick because the font path was not correct

Todos:

Comment threadlib/private/Avatar/Avatar.php Fixed

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks real nice! :)

Comment threadversion.php Outdated
Comment threadcore/Controller/AvatarController.php Outdated
Comment threadcore/Controller/GuestAvatarController.php Outdated
Comment threadlib/private/Avatar/Avatar.php Outdated
Comment threadlib/private/Avatar/Avatar.php
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
And better caching policy
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
CarlSchwanforce-pushed the avatar-new-style branch 2 times, most recently from aea3d11 to 61ee0d9CompareSeptember 9, 2022 12:11
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan

Copy link
Copy Markdown
MemberAuthor

ci failure unrelated (sharing)

@CarlSchwan
CarlSchwan merged commit 4a82396 into masterSep 9, 2022
@CarlSchwan
CarlSchwan deleted the avatar-new-style branch September 9, 2022 13:01
@blizzzblizzz mentioned this pull request Sep 9, 2022
@AndyXheliAndyXheli mentioned this pull request Sep 9, 2022
9 tasks
@ChristophWurst

Copy link
Copy Markdown
Member

This should be documented so apps can adjust. I still see

{"reqId":"wfo0ZhmZNBDzXGliaakN","level":0,"time":"2023-01-26T09:32:37+00:00","remoteAddr":"127.0.0.1","user":"admin","app":"core","method":"GET","url":"/avatar/admin/32?v=4","message":"Avatar requested in deprecated size 32","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Firefox/108.0","version":"26.0.0.2","data":{"app":"core"}}

in my log when I open Dashboard

@ChristophWurst

Copy link
Copy Markdown
Member

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending documentationThis pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@CarlSchwan@ChristophWurst@jancborchardt@github-advanced-security@come-nc@tobiasKaminsky