Skip to content

Add plsam taint analysis baseline - #33779

Closed
CarlSchwan wants to merge 1 commit into
masterfrom
psalm-taint-escape
Closed

Add plsam taint analysis baseline#33779
CarlSchwan wants to merge 1 commit into
masterfrom
psalm-taint-escape

Conversation

@CarlSchwan

Copy link
Copy Markdown
Member

And remove some false positive

@CarlSchwanCarlSchwan added the 3. to review Waiting for reviews label Aug 31, 2022
@CarlSchwanCarlSchwan added this to the Nextcloud 25 milestone Aug 31, 2022
@CarlSchwanCarlSchwan self-assigned this Aug 31, 2022
@blizzzblizzz mentioned this pull request Sep 1, 2022
Comment threadpsalm-taint.xml
This was referenced Sep 6, 2022
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
And remove some false positive
Signed-off-by: Carl Schwan <carl@carlschwan.eu>

@miaulalalamiaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* @return JSONResponse
*/
public function create(string $layout): JSONResponse {
$layout = htmlspecialchars($layout);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention this in your commit message? 😅

@come-nc

Copy link
Copy Markdown
Contributor

Assigning that to me, the taint analysis is already done in an other job, but the docblock and escaping fixes from this PR should still be merged.

@blizzzblizzz mentioned this pull request Feb 1, 2023
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
@blizzzblizzz mentioned this pull request Mar 7, 2023
@blizzzblizzz modified the milestones: Nextcloud 26, Nextcloud 27Mar 9, 2023
@szaimen

Copy link
Copy Markdown
Contributor

conflicts :/

@szaimenszaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 17, 2023
@come-nc

Copy link
Copy Markdown
Contributor

Replaced by #36378 for the relevant parts.

@come-nccome-nc closed this Apr 24, 2023
@szaimen
szaimen deleted the psalm-taint-escape branch April 24, 2023 15:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@CarlSchwan@come-nc@szaimen@nickvergessen@miaulalala@blizzz