Uh oh!
There was an error while loading. Please reload this page.
Improve getting recent files performance - #33788
Conversation
6e041b2 to
1f80db4CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ChristophWurst
left a comment
There was a problem hiding this comment.
Reasonable trade-off
After all it says recent and not most recent 😉
Only do so when asking for less than 100 files and having an offset equal to 0. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
1f80db4 to
67551f3CompareAndyScherzinger
commented
Sep 5, 2022
@CarlSchwan so what are the changes besides only looking at files changed in the last two weeks, would 'changed' also include 'created' and is it now limited to the users storage or just the 2 weeks time frame? Just to check with @karlitschek and @jancborchardt if it is feasible to limit recent files search in this way that it at least works again on larger instances and enables the recommendation app to work again plus in both scenarios not nuke large installations. |
karlitschek
commented
Sep 5, 2022
Sorry. I'm too stupid :-) What does this mean exactly? Is this the recent files view in the files app only? Or for other places too? |
max-nextcloud
commented
Sep 5, 2022
The only change is the 2 weeks time frame. Group folders are included and changed should include created - haven't tested that though.
This will hopefully reduce the database load. On one instance I investigated the main load was sorting the results by timestamp to then pick the 7 most recent. The list of files to sort should be much smaller if only the ones changed in the last two weeks are included... whether it's enough to enable the app again on large instances remains to be seen.
Basically all places that query for recent files. Definitely in the recommendations app. |
CarlSchwan
commented
Sep 8, 2022
So should I merge it? :p |
AndyScherzinger
commented
Sep 8, 2022
Yes, fine by Frank and me behavior-wise |
karlitschek
commented
Sep 8, 2022
I think it's cool! I like it!! |
CarlSchwan
commented
Sep 8, 2022
/backport to stable24 |
CarlSchwan
commented
Sep 8, 2022
/backport to stable23 |
Jerome-Herbinet
commented
Sep 20, 2022
Will this also speed up getting recent files in the Android app ? |
AndyScherzinger
commented
Sep 20, 2022
I am not aware of the app having a recent files view. |
Jerome-Herbinet
commented
Sep 20, 2022
Oh, sorry, I've just seen that I've confused it with the favourites (which, in the Android application, are quite long to display). Forget about my message. |
Only look for files modified in the last 2 weeks