Uh oh!
There was an error while loading. Please reload this page.
Fix translation of user exists error server-side - #33819
Merged
Merged
Conversation
Pytal
requested review from
PVince81 and juliusknorr
and removed request for
a teamSeptember 1, 2022 19:15
Pytal
commented
Sep 1, 2022
MemberAuthor
/backport to stable24 |
CarlSchwan
approved these changes
Sep 1, 2022
Merged
come-nc
approved these changes
Sep 5, 2022
Pytalforce-pushed
the
fix/user-exists-l10n
branch
from
September 9, 2022 20:22
4ba0aeb to
b04b193Compare Merged
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytalforce-pushed
the
fix/user-exists-l10n
branch
from
September 15, 2022 22:56
b04b193 to
8a15c62ComparePytal
commented
Sep 15, 2022
MemberAuthor
Rebased |
1 task
Pytal added a commit
that referenced
this pull request
Sep 16, 2022
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal added a commit
that referenced
this pull request
Sep 19, 2022
Signed-off-by: Christopher Ng <chrng8@gmail.com> (cherry picked from commit 4de19e9)
s8321414 pushed a commit
to MODAODF/odfweb
that referenced
this pull request
May 4, 2023
Signed-off-by: Christopher Ng <chrng8@gmail.com> (cherry picked from commit 4de19e9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert special 102 status code handling on the frontend from #33222 and translate the string server-side instead as the 102 status code does not always mean that the user already exists i.e.
server/apps/provisioning_api/lib/Controller/UsersController.php
Line 377 in f167fe0
server/apps/provisioning_api/lib/Controller/UsersController.php
Line 862 in f167fe0