Uh oh!
There was an error while loading. Please reload this page.
Implement IAPIWidget, IButtonWidget and IIconWidget in user status - #33940
Conversation
248e4fd to
3c34d74Compare3c34d74 to
19b5052Comparejulien-nc
commented
Sep 7, 2022
@tobiasKaminsky The text includes the status unicode character (the UTF-8 emoji). So when there is no emoji, title starts with a space. This is fixed now. About the round icon, tough decision to make. Potential solutions, just elaborating what you said:
I prefer 1. because it is generic and implemented one single time in each client rather than potentially making the effort of rounding the image in each server widget class. |
tobiasKaminsky
commented
Sep 8, 2022
Then let us go with 1. |
tobiasKaminsky
commented
Sep 13, 2022
This lacks IItemOptionWidget so that we have item_icons_round:true ? |
19b5052 to
11391d0Comparerebased and set |
tobiasKaminsky
commented
Sep 13, 2022
Tested & worked 👍 |
be2b7b6 to
2600d0bCompare@icewind1991 Thanks for the adjustments! |
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Robin Appelman <robin@icewind.nl>
11391d0 to
5b25f94Comparejulien-nc
commented
Sep 15, 2022
Rebased on |
julien-nc
commented
Sep 15, 2022
Or we can make the final review in the original PR #33658 |


This is based on #33658
requires:
No buttons for this widget. Use the app svg icon for
getIconUrl().