Uh oh!
There was an error while loading. Please reload this page.
Only normalize data in public shares and not crud - #33941
Merged
Conversation
CarlSchwan
requested review from
PVince81, blizzz and come-nc
and removed request for
a teamSeptember 7, 2022 11:53
artonge
reviewed
Sep 7, 2022
artonge
approved these changes
Sep 7, 2022
Merged
CarlSchwanforce-pushed
the
fix/public-sharing
branch
from
September 8, 2022 10:06
8664df8 to
7f1bfc0Compareblizzz
commented
Sep 8, 2022
Member
@CarlSchwan integration-sharing-v1 failed |
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwanforce-pushed
the
fix/public-sharing
branch
from
September 8, 2022 12:51
7f1bfc0 to
7ded5a7Compare Merged
PVince81
commented
Sep 12, 2022
Member
@CarlSchwan please double check the failing sharing tests to see if related |
Merged
CarlSchwan
commented
Sep 15, 2022
MemberAuthor
Tests work locally, so this seems to be a race condition as I saw the share link acceptance tests fail in other PR recently (probably caused by the redesign) |
mejo-
commented
Oct 26, 2022
Member
@CarlSchwan are you ok with backporting this to stable24? |
PVince81
commented
Jan 2, 2023
Member
/backport to stable24 |
Closed
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.