Skip to content

Use NoteCard component in BackgroundJob settings - #33942

Merged
CarlSchwan merged 1 commit into
masterfrom
background-job-notecart
Sep 8, 2022
Merged

Use NoteCard component in BackgroundJob settings#33942
CarlSchwan merged 1 commit into
masterfrom
background-job-notecart

Conversation

@CarlSchwan

@CarlSchwanCarlSchwan commented Sep 7, 2022

Copy link
Copy Markdown
Member

@CarlSchwanCarlSchwan added the 3. to review Waiting for reviews label Sep 7, 2022
@CarlSchwanCarlSchwan added this to the Nextcloud 25 milestone Sep 7, 2022
@CarlSchwan
CarlSchwan requested a review from a teamSeptember 7, 2022 12:04
@CarlSchwanCarlSchwan self-assigned this Sep 7, 2022
@CarlSchwan
CarlSchwan requested review from PVince81, Pytal and szaimen and removed request for a teamSeptember 7, 2022 12:04
@CarlSchwan
CarlSchwanforce-pushed the background-job-notecart branch from a21dd8d to 04b2a3fCompareSeptember 7, 2022 12:05

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but didnt test

@blizzzblizzz mentioned this pull request Sep 7, 2022
Fix#33880
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
CarlSchwanforce-pushed the background-job-notecart branch from 04b2a3f to 0b77607CompareSeptember 8, 2022 12:13
@szaimenszaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 8, 2022
@CarlSchwan
CarlSchwan merged commit 9900a02 into masterSep 8, 2022
@CarlSchwan
CarlSchwan deleted the background-job-notecart branch September 8, 2022 17:30
@blizzzblizzz mentioned this pull request Sep 9, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: NC 25 Color status button missing for Background jobs "Basic Settings tab"

3 participants

@CarlSchwan@Pytal@szaimen