Uh oh!
There was an error while loading. Please reload this page.
fix 2FA icons - #33962
Merged
Merged
Conversation
szaimen
requested review from
a team, PVince81, Pytal, juliusknorr and skjnldsv
and removed request for
a teamSeptember 8, 2022 10:31
szaimen
marked this pull request as ready for review
September 8, 2022 10:31
CarlSchwan
approved these changes
Sep 8, 2022
Merged
come-nc
approved these changes
Sep 8, 2022
szaimen
commented
Sep 8, 2022
ContributorAuthor
/compile amend / |
skjnldsv
approved these changes
Sep 8, 2022
skjnldsv
reviewed
Sep 8, 2022
| width: 16px; | ||
| height: 16px; | ||
| vertical-align: sub; | ||
| filter: var(--background-invert-if-dark); |
Member
There was a problem hiding this comment.
This entire set of rules should most likely be in the two-factor-auth app, no?
ContributorAuthor
There was a problem hiding this comment.
I think it sjould rather be fixed here as it then applies automatically to all apps. Also is there even a way for an app to overwrite this single place?
Signed-off-by: szaimen <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
enh/33864/fix-2FA-icons
branch
from
September 8, 2022 14:05
8b0f443 to
055a628Compareszaimen
commented
Sep 8, 2022
ContributorAuthor
CI failure unrelated |
9 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close#33864
Signed-off-by: szaimen szaimen@e.mail.de