Uh oh!
There was an error while loading. Please reload this page.
Change default login background to cloud image - #34000
Merged
Merged
Conversation
CarlSchwan
requested review from
PVince81, Pytal and artonge
and removed request for
a teamSeptember 9, 2022 14:14
AndyScherzinger
commented
Sep 9, 2022
Member
bottom line / "claim" is now barely readable |
CarlSchwanforce-pushed
the
change-default-login-background
branch
from
September 9, 2022 14:21
3a6bd82 to
177b2b5CompareAndyScherzinger
approved these changes
Sep 9, 2022
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwanforce-pushed
the
change-default-login-background
branch
from
September 9, 2022 14:24
177b2b5 to
9104222Compare Merged
2 tasks
| cursor: pointer; | ||
| background-color: var(--color-primary); | ||
| background-image: var(--image-background, var(--image-background-plain, url('../../../core/img/background.svg'), linear-gradient(40deg, #0082c9 0%, #30b6ff 100%))); | ||
| background-image: var(--image-background, var(--image-background-plain, url('../../../core/img/app-background.jpg'), linear-gradient(40deg, #0082c9 0%, #30b6ff 100%))); |
There was a problem hiding this comment.
Looks great, and additionally the fallback could be changed from the linear-gradient to the plain color #0082c9 (our primary)? @CarlSchwan
| background-repeat: repeat; | ||
| background-size: var(--image-background-size, 275px, contain); | ||
| background-attachment: fixed; /* fix background gradient */ | ||
| background-image: var(--image-background, var(--image-background-plain, url('../../../core/img/app-background.jpg'), linear-gradient(40deg, #0082c9 0%, #30b6ff 100%))); |
| text-align: center; | ||
| background-color: var(--color-primary); | ||
| background-image: var(--image-background, var(--image-background-plain, url('../../../core/img/background.svg'), linear-gradient(40deg, #0082c9 0%, #30b6ff 100%))); | ||
| background-position: 50% 50%; |
There was a problem hiding this comment.
The background-position: center center; should stay though so it’s exactly like when logged in?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#33968