Skip to content

Use primary button in updater - #34018

Merged
PVince81 merged 1 commit into
masterfrom
use-primary-button-updater
Sep 12, 2022
Merged

Use primary button in updater#34018
PVince81 merged 1 commit into
masterfrom
use-primary-button-updater

Conversation

@CarlSchwan

Copy link
Copy Markdown
Member

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwanCarlSchwan added this to the Nextcloud 25 milestone Sep 12, 2022
@CarlSchwan
CarlSchwan requested a review from a teamSeptember 12, 2022 07:17
@CarlSchwanCarlSchwan self-assigned this Sep 12, 2022
@CarlSchwan
CarlSchwan requested review from PVince81, Pytal and artonge and removed request for a teamSeptember 12, 2022 07:17

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but didnt test

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
PVince81 merged commit 52d962b into masterSep 12, 2022
@PVince81
PVince81 deleted the use-primary-button-updater branch September 12, 2022 13:15
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews25-feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: NC25 Web updater should use primary button

3 participants

@CarlSchwan@PVince81@szaimen